Adding RT-7.12: BGP Drain using Route Policy

[ASHNA-AGGARWAL-KEYSIGHT]

Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/policybase/otg_tests/bgp_drain_policy_test/README.md

Logs attached: https://partnerissuetracker.corp.google.com/u/0/issues/559969425

Bug found: https://partnerissuetracker.corp.google.com/u/0/issues/559968791

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test suite to verify BGP drain behavior via route policies. It leverages the Open Traffic Generator (OTG) to ensure that prefix withdrawals are correctly received and processed, while also verifying traffic loss and restoration scenarios. Additionally, it adds necessary platform-specific configuration deviations to ensure compatibility with Arista hardware.

Highlights

• New Test Implementation: Added a new test file 'bgp_drain_policy_test.go' to validate BGP drain functionality using route policies.
• Documentation Update: Updated the README to reflect the use of OTG for validating prefix withdrawals.
• Metadata Configuration: Updated 'metadata.textproto' to include platform-specific deviations for Arista devices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #6023 / b1a1ff3

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-7.12: BGP Drain using Route Policy
Cisco 8000E		RT-7.12: BGP Drain using Route Policy
Cisco XRd		RT-7.12: BGP Drain using Route Policy
Juniper ncPTX		RT-7.12: BGP Drain using Route Policy
Nokia SR Linux		RT-7.12: BGP Drain using Route Policy
Openconfig Lemming		RT-7.12: BGP Drain using Route Policy

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista		RT-7.12: BGP Drain using Route Policy
Cisco		RT-7.12: BGP Drain using Route Policy
Juniper		RT-7.12: BGP Drain using Route Policy
Nokia		RT-7.12: BGP Drain using Route Policy

Help

[gemini-code-assist]

Code Review

This pull request introduces a new BGP drain policy test (bgp_drain_policy_test.go) along with updates to its README.md and metadata.textproto to include Arista platform exceptions. The reviewer feedback focuses on improving test robustness and alignment with repository style guides. Key recommendations include replacing a static time.Sleep with a deterministic gnmi.Watch-based check before stopping packet capture, deferring file cleanup operations to prevent resource leaks on early test failures, ensuring packet captures are stopped in a deferred block, and explicitly waiting for ARP resolution after starting protocols before initiating traffic.