DP-1.17: use per-flow OTG telemetry for tagged metrics polling - #6020
DP-1.17: use per-flow OTG telemetry for tagged metrics polling#6020dipchauh wants to merge 1 commit into
Conversation
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the DSCP transparency test to use per-flow OTG telemetry for collecting tagged metrics. By moving away from a broad global query, the test ensures reliable metric collection on hardware with limited scale, such as Novus-R cards, while maintaining existing validation logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #6020 / af595abVirtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes the waitForAndGetTaggedMetrics function in dscp_transparency_test.go by querying telemetry for specific flow names instead of using a wildcard query for all flows. It maps expected metric IDs to specific queue names (such as BE1, BE0, AF1-4, NC1) to construct the target flow names, reducing the volume of telemetry data retrieved during the polling loop. There are no review comments, and I have no additional feedback to provide.
2 participants
Replace
FlowAny()with per-flow OTG telemetry when polling for tagged metrics, similar to other tests. This ensures tagged metrics are collected properly on reduced-scale Ixia cards (eg. Novus-R)"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."