Skip to content

changing the timeout of the binding files #6018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhijit-dhar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

changing the timeout of the binding files #6018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions topologies/otgdut_2.binding
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ ates {
otg {
target: "ixia-c-hostname:40051" # Change this to the Ixia-c-grpc server endpoint.
insecure: true
timeout: 30
timeout: 540
Comment thread
abhijit-dhar marked this conversation as resolved.
}

gnmi {
target: "ixia-c-hostname:50051" # Change this to the Ixia-c-gnmi server endpoint.
skip_verify: true
timeout: 30
timeout: 540

@gemini-code-assist gemini-code-assist Bot Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Increasing the gNMI request timeout to 540 seconds (9 minutes) is excessively high. If a gNMI operation hangs, waiting 9 minutes will block the test suite and waste CI/CD resources. A timeout of 120 seconds is typically sufficient to handle transient delays while ensuring the test fails within a reasonable timeframe.

Suggested change
timeout: 540
timeout: 120

@abhijit-dhar abhijit-dhar Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I insists the change because for most cases the API will return within a few seconds but for genuinely costly operations such as large learned info or stats , we need more time to respond, so a large timeout avoids false negatives and subsequent failures for subsequent tests

}

# Before this binding can be used with a topology, add ports mapping
Expand Down
4 changes: 2 additions & 2 deletions topologies/otgdut_4.binding
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,13 @@ ates {
otg {
target: "ixia-c-hostname:40051" # Change this to the Ixia-c-grpc server endpoint.
insecure: true
timeout: 30
timeout: 540
Comment thread
abhijit-dhar marked this conversation as resolved.
}

gnmi {
target: "ixia-c-hostname:50051" # Change this to the Ixia-c-gnmi server endpoint.
skip_verify: true
timeout: 30
timeout: 540
Comment thread
abhijit-dhar marked this conversation as resolved.
}

# Before this binding can be used with a topology, add ports mapping
Expand Down
Loading