Code fix to skip empty slots - #6016
mnp-juniper wants to merge 3 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the accuracy of inventory telemetry by ensuring that only populated FRU slots are processed. By checking the component state for empty values, the script prevents unnecessary data collection from vacant slots, leading to more reliable inventory reporting. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #6016 / 642eeffVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request updates the TestDefaultPowerAdminState function in telemetry_inventory_test.go to skip components if their slot is empty by checking c.GetEmpty(). There are no review comments provided, and I have no additional feedback on these changes.
Issue:
The script was collecting all fru slots without checking the fru is present in the slot or not.
Fix:
Check the component state/empty value and skip the slot if it is empty.