Skip to content

Code fix to skip empty slots - #6016

Open
mnp-juniper wants to merge 3 commits into
openconfig:mainfrom
mnp-juniper:gnmi1.4
Open

mnp-juniper wants to merge 3 commits into
openconfig:mainfrom
mnp-juniper:gnmi1.4

Conversation

@mnp-juniper

Copy link
Copy Markdown
Contributor

Issue:
The script was collecting all fru slots without checking the fru is present in the slot or not.
Fix:
Check the component state/empty value and skip the slot if it is empty.

@mnp-juniper
mnp-juniper requested a review from a team as a code owner September 10, 2026 07:36
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the accuracy of inventory telemetry by ensuring that only populated FRU slots are processed. By checking the component state for empty values, the script prevents unnecessary data collection from vacant slots, leading to more reliable inventory reporting.

Highlights

  • Inventory Collection Logic: Added a validation check to skip empty FRU slots during the inventory collection process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented Sep 10, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #6016 / 642eeff

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-1.4: Telemetry: Inventory
Cisco 8000E status
gNMI-1.4: Telemetry: Inventory
Cisco XRd status
gNMI-1.4: Telemetry: Inventory
Juniper ncPTX status
gNMI-1.4: Telemetry: Inventory
Nokia SR Linux status
gNMI-1.4: Telemetry: Inventory
Openconfig Lemming status
gNMI-1.4: Telemetry: Inventory

Hardware Devices

Device Test Test Documentation Raw Log
Arista status
gNMI-1.4: Telemetry: Inventory
Cisco status
gNMI-1.4: Telemetry: Inventory
Juniper status
gNMI-1.4: Telemetry: Inventory
Nokia status
gNMI-1.4: Telemetry: Inventory

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TestDefaultPowerAdminState function in telemetry_inventory_test.go to skip components if their slot is empty by checking c.GetEmpty(). There are no review comments provided, and I have no additional feedback on these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants