Add TE-2.3 gRIBI IPv6 entry test with prefix lengths > 64 - #6012
Add TE-2.3 gRIBI IPv6 entry test with prefix lengths > 64#6012nafis-google wants to merge 2 commits into
Conversation
Implement test plan TE-2.1 for IPv6 in featureprofiles under feature/gribi/otg_tests/ipv6_entry_test, branched out of ipv4_entry_test. Validates gRIBI IPv6 route programming and forwarding for prefix lengths strictly greater than /64, including: - Boundary prefix length sweeps (/65, /96, /126, /127, /128) - Longest Prefix Match (LPM) discrimination (/64 vs /65) - Multipath / ECMP across multiple next-hops - MAC address overwrite - Downed interface packet drop - gRIBI FlushAll
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new automated test suite for gRIBI IPv6 entry handling, specifically targeting prefix lengths exceeding 64 bits. The implementation ensures that device agents and switch ASICs correctly manage longer IPv6 prefixes without truncation or lookup failures, providing robust validation for complex routing scenarios. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #6012 / 60c95b0Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request implements the TE-2.1 test plan to validate gRIBI IPv6 route entry support for prefix lengths strictly greater than 64 bits, including test cases for single/multiple next-hops, MAC overrides, downed interfaces, LPM discrimination, and boundary prefix sweeps. The feedback recommends aligning the test implementation with the repository style guide by calling otgutils.WaitForARP before starting traffic to ensure deterministic neighbor resolution, and refactoring the staticARPWithMagicUniversalIP helper to register its cleanup operations using t.Cleanup() directly inside the function.
- Update test plan ID to TE-2.3 to avoid conflict with TE-2.1 (IPv4 entry) - Add Canonical OC JSON section to README.md - Sync test registry in testregistry.textproto - Register static route cleanup via t.Cleanup inside staticARPWithMagicUniversalIP
Implement test plan TE-2.3 for IPv6 in featureprofiles under feature/gribi/otg_tests/ipv6_entry_test, branched out of ipv4_entry_test. It is simply ipv4 tests modified with ipv6 params.
Validates gRIBI IPv6 route programming and forwarding for prefix lengths strictly greater than /64, including:
This test tries to install static IPV6, Next-hop and Next-hop-group and validates correct traffic matching.