TRANSCEIVER-10.1/TRANSCEIVER-6.1/TRANSCEIVER-11.2 : optical-transport : Update terminal-device model for logical channel assignments

[priyaranjannanda]

• Changes to Update terminal-device model for logical channel assignments

https://github.com/openconfig/public/blob/6039bd7b294ad45161da3a258e7f6b4e48b0495c/release/models/optical-transport/openconfig-terminal-device.yang#L1250

snippet as below

leaf interface {
type oc-if:base-interface-ref;
description
"Reference to the interface carrying the input signal
for the logical channel. The ingress will specify an interface
in the case of a transceiver being utilized directly in a
router and bypassing a dedicated terminal device. **When
specified, the other leaves in the ingress config must be
empty.";
}
}

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the terminal-device configuration logic to align with recent changes in the OpenConfig terminal-device model. By removing the transceiver reference from the ingress parameters, the implementation ensures consistency with the updated logical channel assignment requirements.

Highlights

• Terminal-device model alignment: Removed the Transceiver field from the oc.TerminalDevice_Channel_Ingress struct within the ConfigETHChannel function to comply with updated OpenConfig model specifications.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #6003 / 12c460c

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

This pull request removes the Transceiver field assignment from the ingress configuration in ConfigETHChannel within internal/cfgplugins/interface.go. The reviewer points out that a similar change is needed in updateETHChannelConfig to prevent schema validation failures, as the same YANG constraint applies there.