Skip to content

Adding IS-IS suppress interface reachability test plan - #5998

Open
AsliSevil wants to merge 3 commits into
openconfig:mainfrom
AsliSevil:feature/rt-2.19-isis-reachability-suppression
Open

Adding IS-IS suppress interface reachability test plan#5998
AsliSevil wants to merge 3 commits into
openconfig:mainfrom
AsliSevil:feature/rt-2.19-isis-reachability-suppression

Conversation

@AsliSevil

Copy link
Copy Markdown

Description

This PR adds the test plan and test registry entry for RT-2.19: IS-IS Suppress Interface Reachability.

Summary of Changes:

  • feature/isis/otg_tests/isis_suppress_interface_reachability_test/README.md: Test plan covering telemetry state checks and ATE LSP verification across suppression modes (NONE, ALL, NON_PASSIVE, NON_PASSIVE_POINT_TO_POINT).
  • testregistry.textproto: Registered test RT-2.19.

Testbed:

  • topologies/atedut_2.testbed

@AsliSevil
AsliSevil requested review from a team as code owners September 8, 2026 09:11
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test plan for validating IS-IS interface reachability suppression. It outlines procedures to verify that the Device Under Test (DUT) correctly handles prefix reachability advertisement across different suppression modes while maintaining stable IS-IS adjacencies.

Highlights

  • New Test Plan: Added a comprehensive test plan for RT-2.19: IS-IS Suppress Interface Reachability, covering various suppression modes and telemetry verification.
  • Test Registration: Registered the new test case RT-2.19 in the test registry.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented Sep 8, 2026

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test plan (RT-2.19) for validating IS-IS Suppress Interface Reachability, including a detailed README.md and metadata.textproto. The reviewer feedback suggests formatting subtest headings to match the test plan template, explicitly utilizing t.Cleanup() for configuration restoration in the test plan steps, and adding the missing state path /network-instances/network-instance/protocols/protocol/isis/global/state/net to the coverage section for completeness.

Comment thread feature/isis/otg_tests/isis_suppress_interface_reachability_test/README.md Outdated
Comment thread feature/isis/otg_tests/isis_suppress_interface_reachability_test/README.md Outdated
@AsliSevil
AsliSevil force-pushed the feature/rt-2.19-isis-reachability-suppression branch from 75ff581 to ec8bbc1 Compare September 8, 2026 09:14
@AsliSevil AsliSevil changed the title testplan(isis): add RT-2.19 IS-IS suppress interface reachability test plan Adding RT-2.19 IS-IS suppress interface reachability test plan Sep 9, 2026
@AsliSevil AsliSevil changed the title Adding RT-2.19 IS-IS suppress interface reachability test plan Adding IS-IS suppress interface reachability test plan Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants