Handle cancelled MCP session operations#298
Open
dongyikuan919 wants to merge 1 commit into
Open
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes part of the stale/zombie MCP session behavior described in #90 by handling
asyncio.CancelledErrorduring MCP session operations instead of letting it escape the request path.Changes:
CancelledErrorwhile unwinding partially opened sessions/transportsHTTPExceptiondetails from tool errors instead of wrapping them asUnexpected errorValidation
python -m py_compile src/mcpo/main.py src/mcpo/utils/main.py src/mcpo/tests/test_main.pypython -m pytest src/mcpo/tests/test_main.py-> 18 passedI also attempted the broader test run through
uv run, but dependency installation failed while fetchinghttps://pypi.org/simple/cryptography/due to a network timeout in this environment.