overlay: fail the build when a post-overlay hook fails#338
Open
mRrvz wants to merge 1 commit into
Open
Conversation
apply_custom_overlay() runs every script in the overlay's .overlay-hooks directory, but a hook that exited non-zero was only reported as a "WARNING" and otherwise ignored: the loop kept going and the function still returned success. As a result a failing hook (for example, a package that could not be installed into the image) was invisible to the callers, and the image was built and shipped as if the overlay had applied cleanly. Make hook failures fatal. Signed-off-by: Alexey Romanov <romanov.alexey2000@gmail.com>
mRrvz
force-pushed
the
feature/fail_if_postoverlay_hook_fail
branch
from
July 16, 2026 08:01
fc4f96b to
f9cbffe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply_custom_overlay() runs every script in the overlay's .overlay-hooks directory, but a hook that exited non-zero was only reported as a "WARNING" and otherwise ignored: the loop kept going and the function still returned success. As a result a failing hook (for example, a package that could not be installed into the image) was invisible to the callers, and the image was built and shipped as if the overlay had applied cleanly. Make hook failures fatal.