install_help: add BEName() to allow configuring the boot environment name#336
Open
mRrvz wants to merge 1 commit into
Open
install_help: add BEName() to allow configuring the boot environment name#336mRrvz wants to merge 1 commit into
mRrvz wants to merge 1 commit into
Conversation
mRrvz
changed the title
…name
Add a BEName() function, modelled after RootPW(), that lets install
scripts or configuration profiles override the boot environment name
before installation begins.
- BENAME is initialised with ${BENAME:-omnios} so that a value set
in an environment-specific defs.sh (sourced before install_help.sh)
is preserved rather than overwritten.
- A companion flag BENAME_SET is cleared at module load and set by
BEName(). Installer scripts append the OS version from /etc/release
to the BE name only when BENAME_SET is unset, preserving the
existing omnios-r151056t naming convention for default installs while
allowing downstream distributions to supply a fully-formed name that
is used as-is.
- BuildBE() and MakeBootable() default to $BENAME instead of the
hardcoded string "omnios", so the PXE/network install path also
honours the configured name.
- Installer scripts (dialog-install, rpool-install) call BEName $BENAME
explicitly after sourcing install_help.sh so the function is exercised
and any pre-set value flows through correctly.
Signed-off-by: Alexey Romanov <romanov.alexey2000@gmail.com>
mRrvz
force-pushed
the
feature/configurable-bename
branch
from
April 28, 2026 13:36
9a44a47 to
feca54a
Compare
Author
|
Hi guys! Gentle reminder. |
citrus-it
reviewed
May 18, 2026
| ver=`head -1 /etc/release | awk '{print $3}'` | ||
| [ -n "$ver" ] && bename+="-$ver" | ||
| bename=$BENAME | ||
| if [ -z "$BENAME_SET" ]; then |
Member
There was a problem hiding this comment.
Isn't this always going to be false because you have called BEName up at line 28? Same comment for rpool-install.
We should still default to omnios-r151058 or whatever, depending on the version being installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a BEName() function, modelled after RootPW(), that lets install
scripts or configuration profiles override the boot environment name
before installation begins.
BENAME is initialised with ${BENAME:-omnios} so that a value set
in an environment-specific defs.sh (sourced before install_help.sh)
is preserved rather than overwritten.
A companion flag BENAME_SET is cleared at module load and set by
BEName(). Installer scripts append the OS version from /etc/release
to the BE name only when BENAME_SET is unset, preserving the
existing omnios-r151056t naming convention for default installs while
allowing downstream distributions to supply a fully-formed name that
is used as-is.
BuildBE() and MakeBootable() default to $BENAME instead of the
hardcoded string "omnios", so the PXE/network install path also
honours the configured name.
Installer scripts (dialog-install, rpool-install) call BEName $BENAME
explicitly after sourcing install_help.sh so the function is exercised
and any pre-set value flows through correctly.