Repository navigation
fix: improve legacy Cast receiver compatibility - #6
tomasmark79 wants to merge 6 commits into
Conversation
d4d6992 to
3b2c4a0
Compare
| /// decoder stops consuming the stream shortly after a large 1080p frame. | ||
| /// Keep this deliberately narrow until the quirk is confirmed elsewhere. | ||
| pub fn requires_vp8_mirroring(&self) -> bool { | ||
| matches!(self.model.as_str(), "OLED55C21LA") |
There was a problem hiding this comment.
I prefer an option in the settings/preferences instead of this.
I know it's not the best case, specially if you have multiple devices, but in that case, in the future we can create profiles in the settings, so users can define preset profiles per device id/name.
There was a problem hiding this comment.
Agreed. I removed the model-specific quirk and replaced it with a Video codec preference (Automatic, VP8, VP9, H.264, AV1). Automatic preserves the existing negotiation; users with an incompatible receiver can force VP8. The preference is wired through GSettings and D-Bus into the OFFER, documented, translated, tested, and live-tested at 1080p30 on the affected LG. I also rebased the branch onto the current hardware-encoding head.
b2bfc40 to
c2fd6d3
Compare
| </choices> | ||
| <default>'auto'</default> | ||
| <summary>Video codec</summary> | ||
| <description>Which codec to offer for Cast Streaming. "auto" offers every codec available on this computer and lets the receiver choose. Force VP8 when a receiver freezes or displays a broken picture with another codec.</description> |
There was a problem hiding this comment.
This text here is too much and can be wrong technically: Force VP8 when a receiver freezes or displays a broken picture with another codec.. Please ask your AI to not develop just specifically for your case.
|
|
||
| #: extension/gnome-shell-cast@oxygenws.com/prefs.js:170 | ||
| msgid "Choose VP8 if the receiver freezes or displays a broken picture" | ||
| msgstr "" |
There was a problem hiding this comment.
Good that it's missing... but anyway... it's missing :D
| "Which codec to offer for Cast Streaming. \"auto\" offers every codec " | ||
| "available on this computer and lets the receiver choose. Force VP8 when a " | ||
| "receiver freezes or displays a broken picture with another codec." | ||
| msgstr "" |
There was a problem hiding this comment.
This is also missing.
There is a skill to update translations, prefer that over manually touching translations
|
Thanks. |
|
Ok. I'll go through the requirements. I'm still working on the issue with the delayed audio channel, so I'll push it all at once after that. |
2 participants
Summary
flake.lockso Nix builds use a reproducible dependency setValidation
cargo test(96 passed)cargo clippy --all-targets -- -D warningsnix flake check --no-buildNix dependency lock
The lock file pins
nixpkgsto34ab99075ac4f7e40cf037eef32cb1c360bb85e9(nixos-unstable). It makes the Rust, GStreamer, and other build inputs reproducible; it does not contain receiver-specific configuration.Notes
The five commits are kept separate by concern. Automatic codec selection preserves the existing behaviour. A forced codec is an explicit compatibility escape hatch; per-device profiles can build on this preference later.