Skip to content

Remove reference library module#65

Open
FikriMilano wants to merge 7 commits into
ohs-foundation:mainfrom
FikriMilano:64-remove-reference-library-module
Open

Remove reference library module#65
FikriMilano wants to merge 7 commits into
ohs-foundation:mainfrom
FikriMilano:64-remove-reference-library-module

Conversation

@FikriMilano

@FikriMilano FikriMilano commented Jul 15, 2026

Copy link
Copy Markdown
Member

Fixes #64 #56

  • Remove all artifacts of the reference-library from the client app

  • Replaces the direct module call with actual dependency Use the remote reference-library after available on Maven Central #56

  • Rework the readme of client-app

  • Rename rootProject.name to ohs-player-reference-client-app

  • Update the imports from dev.ohs.player.library.* to dev.ohs.player.reference.library.*

  • All CI build checks pass e.g. Tests

  • Appropriate changes to documentation are included in the PR

@FikriMilano
FikriMilano requested a review from ellykits July 15, 2026 07:27
@FikriMilano FikriMilano self-assigned this Jul 15, 2026
@FikriMilano

Copy link
Copy Markdown
Member Author

Blocked:
Need the alpha01 release of https://github.com/ohs-foundation/ohs-player-reference-client-library

@FikriMilano FikriMilano linked an issue Jul 15, 2026 that may be closed by this pull request

@FikriMilano FikriMilano left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellykits please add some pointers about the README.md

@ellykits ellykits left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the documentation for the reference app, please add these content (unordered):

  1. How to get started with this GitHub template
  2. How to customize and personalize the code, like package
  3. The OHS foundation libraries that are bandled with the reference app (changing application name, icon etc)
  4. How to run the reference app for those who just want to see OHS in action
  5. Developer setup for KMP multiplatform
  6. How to use the OHS player reference library for users with existing implementation who cannot afford to tweak this template for their use case
  7. Mention the supported platforms and how they can be deployed via Git CI

Please add any relevant info that I may have left out. You can order the items above in the README. You don't have to get into a lot of details.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread settings.gradle.kts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove reference-library from the client app Use the remote reference-library after available on Maven Central

2 participants