Repository navigation
Correct the stop_reason 'Other' examples in the ai_status object - #1779
Merged
floydtree merged 4 commits intoOct 16, 2026
Merged
Conversation
The examples for the Other (99) case were end_turn and max_tokens, which both map to defined values (End of Turn (1), Token Limit (2)) and therefore carry the enum caption, not the source's native label. Replaced with a caption example for the mapped branch and two genuinely unmapped native labels for Other. Addresses the review comment from mikeradka on ocsf#1704. Signed-off-by: Levaj2000 <120221487+Levaj2000@users.noreply.github.com>
Levaj2000
requested review from
Aniak5,
davemcatcisco,
floydtree,
jasonbreimer,
mikeradka,
pagbabian-splunk and
zschmerber
as code owners
October 13, 2026 18:34
Schema Description ReviewAutomated suggestions for improving description clarity for LLM consumption. These are advisory — not required changes.
|
Signed-off-by: Levaj2000 <120221487+Levaj2000@users.noreply.github.com>
floydtree
requested changes
Oct 14, 2026
stop_reason shipped in the current dev version under its own changelog entry, so this bugfix PR needs no separate entry. Per floydtree's review. Signed-off-by: Levaj2000 <120221487+Levaj2000@users.noreply.github.com>
pagbabian-splunk
approved these changes
Oct 16, 2026
mikeradka
approved these changes
Oct 16, 2026
floydtree
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue:
Follow-up to #1704 — review comment from @mikeradka:
#1704 (comment)
Description of changes:
The
stop_reasondescription inobjects/ai_status.jsonofferedend_turnandmax_tokensas examples of the native label carried whenstop_reason_idisOther (99). Both of those map cleanly onto defined values —end_turn→End of Turn (1),
max_tokens→ Token Limit (2) — so under the rule stated inthe same sentence they populate
stop_reasonwith the enum caption, never thenative label. The examples contradicted the rule they illustrated.
Left as-is, a producer following the example would write
max_tokenswhereanother writes
Token Limitfor the identical condition, which makes the siblingstring unqueryable. That is the drift the caption-normalization rule exists to
prevent.
This replaces them with one example per branch: a caption for the mapped case,
and two genuinely unmapped native labels for the
Othercase.Before
After
recitationandmalformed_function_callhave no home in the seven-valuetaxonomy, so they are correct illustrations of the
Othercase. Deliberatelyavoided
refusal/content_filter/guardrail_intervened(all ContentFilter (5)) and
stop_sequence(End of Turn (1), per that value's owndescription).
Why this is separate from #1704
Split out by agreement with @mikeradka so a one-line description change didn't
reset that PR's three approvals before the 1.10 cutoff. #1704 has since merged.
Scope
objects/ai_status.jsononly. The genericstop_reasonindictionary.jsoncarries no examples and needs nothing;
permission_resulthas the samesentence shape but no examples.
Validation
runs the same metaschema, compile and compatibility checks.