[3.24.1] Backport #14904#15457
Open
shonfeder wants to merge 1 commit into
Open
Conversation
…14904) When generating jsoo library archive rules on demand, resolve the library stanza the same way Ml_sources does: evaluate enabled_if and pick the enabled stanza rather than the first one matching by name. Fixes an internal error (modules_and_obj_dir: failed lookup) when a dune file defines two libraries with the same name distinguished by mutually exclusive enabled_if clauses, as ocaml-re does for ppx_expect_common. Fixes #14775. (cherry picked from commit b0313ac) Signed-off-by: Shon Feder <shon.feder@gmail.com>
shonfeder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #14904 onto 3.24.1
Replaces #15451, which was incorrectly targeting
main.