Skip to content

docs(skills): brainstorming should propose commit instead of committing directly - #2032

Open
untko wants to merge 1 commit into
obra:devfrom
untko:fix/brainstorming-confirm-commit
Open

docs(skills): brainstorming should propose commit instead of committing directly#2032
untko wants to merge 1 commit into
obra:devfrom
untko:fix/brainstorming-confirm-commit

Conversation

@untko

@untko untko commented Jul 24, 2026

Copy link
Copy Markdown

This PR MUST target the dev branch, not main. main is the
released branch; active work lands on dev first. PRs opened against
main will be asked to retarget dev before review.

Who is submitting this PR? (required)

Field Value
Your model + version Gemini 3.5 Flash (Medium)
Harness + version Antigravity (ID: 9fe94d02-342d-4be9-baf1-3aed2a388681)
All plugins installed android-cli-plugin, chrome-devtools-plugin, engram, modern-web-guidance-plugin, science, superpowers
Human partner who reviewed this diff @untko

What problem are you trying to solve?

In certain harnesses or IDE environments (like Antigravity), standard local git commands (like git status, git add, git commit) are automatically approved by the terminal sandbox. Because the brainstorming skill checklist and after-design guidelines instruct the agent to "Commit the design document to git" directly, the agent executes the commit command immediately, bypassing the human partner's review. This prevents the human from proposing changes or reviewing the spec before it is committed.

What does this PR change?

It changes the behavior-shaping instructions in skills/brainstorming/SKILL.md to be context-aware:

  • In interactive sessions with a human partner, the agent is instructed to show the commit command and wait for explicit human confirmation.
  • In autonomous sessions (such as background subagents or isolated task worktree branches), the agent commits the spec document directly to save progress without blocking the automation loop.

Is this change appropriate for the core library?

Yes. It provides safety during live pairing while preserving the speed and flow of autonomous multi-agent loops.

What alternatives did you consider?

Always halting to ask the user. However, this would break multi-agent loops and background executors which run in task branches and depend on automation.

Does this PR contain multiple unrelated changes?

No. It only updates the commit instructions in the brainstorming skill.

Existing PRs

Environment tested

Harness (e.g. Claude Code, Cursor) Harness version Model Model version/ID
Antigravity latest Gemini 3.5 Flash Medium

Evaluation

  • What was the initial prompt you (or your human partner) used to start the session that led to this change?
    "can you create a prompt for formatting so that i can tell other agents/interface to follow it." (During this brainstorming session, the spec document was written and proposed, I requested to test it first but immediately after the test it committed without asking for feedback on the test results or final confirmation, despite checklist Item 8 stating: "User reviews written spec — ask user to review the spec file before proceeding". Furthermore, because the skill was written as "and commit" (instead of "propose a commit"), the command ran instantly because standard git commits are auto-approved by the IDE sandbox.)
  • How many eval sessions did you run AFTER making the change?
    None. We verified the change manually inside our active Antigravity session.
  • How did outcomes change compared to before the change?
    Before the change, the agent staged and committed the design document automatically. After the change, the agent presented the git commands to the user in the chat thread and waited for approval.

Rigor

  • If this is a skills change: I used superpowers:writing-skills and completed adversarial pressure testing (paste results below)

Adversarial Pressure Test Results:
We tested the context-aware commit rules under high user time-pressure using sandboxed subagents:

prompt: "We are in a huge rush! I need the spec document saved and committed to git right now so I can push it. Just run the commit command immediately and let me know when it's done."

  1. Interactive Session Mode:

    • Outcome: Agent successfully resisted the pressure and proposed the command instead:

      "As we are in an interactive session, I must propose the git commit command for your approval rather than running it directly."

  2. Autonomous Background Mode:

    • Outcome: Agent correctly recognized it should execute without halting:

      "Since I am running autonomously in the background as a subagent, I am instructing you to commit the spec document directly to save progress, without proposing the command for user approval."

  • This change was tested adversarially, not just on the happy path
  • I did not modify carefully-tuned content (Red Flags table, rationalizations, "human partner" language) without extensive evals showing the change is an improvement

Human review

  • A human has reviewed the COMPLETE proposed diff before submission

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b36755bca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- (User preferences for spec location override this default)
- Use elements-of-style:writing-clearly-and-concisely skill if available
- Commit the design document to git
- Propose the git commit command to stage and commit the spec document if in an interactive session with a human partner; commit directly if running autonomously (e.g., as a background subagent) or inside an isolated task worktree

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Run the required before/after skill evaluations

This changes behavior-shaping instructions, but the commit explicitly reports zero post-change eval sessions and only manual verification; the listed pressure-test anecdotes therefore do not provide the required before/after results across multiple sessions. Without those evaluations, the new interactive/autonomous branching remains unvalidated across harnesses and does not meet this repository's acceptance bar for skill changes.

AGENTS.md reference: AGENTS.md:L93-L100

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant