fix(codex): make package timestamps timezone-independent#2007
Draft
SeuPut0705 wants to merge 1 commit into
Draft
fix(codex): make package timestamps timezone-independent#2007SeuPut0705 wants to merge 1 commit into
SeuPut0705 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR? (required)
What problem are you trying to solve?
Running
tests/codex/test-package-codex-plugin.shon macOS in Asia/Seoul produced two timestamp failures. ZIP entries were stored as(1980, 1, 1, 9, 0, 0)instead of midnight, and the tar assertion compared a localized date string (Dec 31 1969) with macOS bsdtar'sJan 1 1970display.Direct reproduction showed that UTC and Asia/Seoul ZIP packages had different SHA-256 values and stored
00:00versus09:00, while both tar packages were byte-identical and had raw membermtimevalues of0. The ZIP command inherited the host timezone even though the precedingtouchran under UTC; the tar test was inspecting presentation text rather than archive metadata.What does this PR change?
Run Info-ZIP with
TZ=UTC, add a regression test that compares real ZIP bytes produced under UTC and Asia/Seoul, and inspect tar member mtimes through Python'starfileAPI instead of localizedtar -tvfoutput.Is this change appropriate for the core library?
Yes. This fixes the repository's Codex packaging script and its integration test without adding dependencies or changing skill behavior. Deterministic portal packages benefit every maintainer producing the official Codex archive.
What alternatives did you consider?
touch: this is the current behavior and leaves Info-ZIP's DOS timestamp conversion timezone-dependent.tar -tvfunder a forced locale/timezone: the rendered date remains tool-specific; rawmember.mtimeis the portable archive contract.Does this PR contain multiple unrelated changes?
No. The one-line packaging fix and both test changes address the same archive timestamp determinism defect.
Existing PRs
package-codex-plugin timestamp,archive timezone deterministic, orCodex package zipin open/closed PRs and issues.Environment tested
New harness support
Not applicable. This PR does not add or change harness support.
Evaluation
mtime == 0; the marketplace manifest test andgit diff --checkalso pass.Rigor
superpowers:writing-skillsis not applicable.Human review