Skip to content

fix: proper XDG base dir support using rc9 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
computed-fn wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: proper XDG base dir support using rc9 #465

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ab1c45
fix: proper XDG base dir support using rc9
computed-fn Jul 22, 2026
7be9d13
fix: maintain backward compatible config read
computed-fn Jul 22, 2026
2b033c4
Fix CI for windows
computed-fn Jul 24, 2026
217bb47
fix: potential issue of rc9 failing to write to non existing director…
computed-fn Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ async function _checkDisabled(dir: string): Promise<string | false | undefined>
return 'by ' + resolve(dir, RC_FILENAME)
}

if (disabledByConf(rc.readUser({ name: RC_FILENAME }))) {
if (disabledByConf(rc.readUserConfig({ name: RC_FILENAME }))) {

@danielroe danielroe Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this still support ~/.nuxtrc (ie backwards compatibility)?

@computed-fn computed-fn Jul 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh right, I forgot about that

@computed-fn computed-fn Jul 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be backward compatible now. Just need to add the new config read is all instead of replacing the old one

return 'by ' + resolve(homedir(), RC_FILENAME)
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
}
Expand All @@ -172,7 +172,7 @@ async function showStatus(dir: string, global: boolean) {
function setRC(dir: string, key: any, val: any, global: boolean) {
const update = { [key]: val }
if (global) {
rc.updateUser(update, RC_FILENAME)
rc.updateUserConfig(update, RC_FILENAME)
}
else {
rc.update(update, { name: RC_FILENAME, dir })
Expand Down
4 changes: 2 additions & 2 deletions src/utils/nuxtrc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { updateUser } from 'rc9'
import { updateUserConfig } from 'rc9'

export function updateUserNuxtRc(key: string, val: string | number | boolean) {
updateUser({ [key]: val }, '.nuxtrc')
updateUserConfig({ [key]: val }, '.nuxtrc')
}
Loading