Skip to content

fix: create server api errors with nitro's own h3 #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cirolosapio wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix: create server api errors with nitro's own h3 #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export default defineNuxtModule<ModuleOptions>({

nuxt.options.nitro.virtual ||= {}
nuxt.options.nitro.virtual['#nuxt-icon-server-runtime'] = usesNitroV3
? `export { defineCachedHandler } from 'nitro/cache'`
: `export { defineCachedEventHandler as defineCachedHandler } from 'nitropack/runtime'`
? `export { defineCachedHandler } from 'nitro/cache'\nexport { createError } from 'nitro/h3'`
: `export { defineCachedEventHandler as defineCachedHandler } from 'nitropack/runtime'\nexport { createError } from 'h3'`
nuxt.options.nitro.virtual['#nuxt-icon-server-options'] = () =>
`export default ${JSON.stringify({
iconifyApiEndpoint: options.iconifyApiEndpoint,
Expand Down
4 changes: 2 additions & 2 deletions src/runtime/server/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { getIcons } from '@iconify/utils'
import { hash } from 'ohash'
import { createError, type H3Event } from 'h3'
import type { H3Event } from 'h3'
import { parseQuery, parsePath } from 'ufo'
import { consola } from 'consola'
import options from '#nuxt-icon-server-options'
import { defineCachedHandler } from '#nuxt-icon-server-runtime'
import { createError, defineCachedHandler } from '#nuxt-icon-server-runtime'
import { collections } from '#nuxt-icon-server-bundle'

const warnOnceSet = /* @__PURE__ */ new Set<string>()
Expand Down
2 changes: 2 additions & 0 deletions src/shim.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ declare module '#nuxt-icon-server-options' {

declare module '#nuxt-icon-server-runtime' {
import type { defineCachedEventHandler } from 'nitropack/runtime'
import type { createError as _createError } from 'h3'

export const defineCachedHandler: typeof defineCachedEventHandler
export const createError: typeof _createError
}
Loading