Fix tmpfiles activation#493
Draft
jmikedupont2 wants to merge 2 commits into
Draft
Conversation
added 2 commits
June 13, 2026 17:05
Replace cargoLock.lockFile with cargoVendorDir = "vendor" so the build is fully pure — no network access to crates.io needed. All 107 crate dependencies are vendored locally via cargo vendor. This follows principle numtide#3 (pure Nix builds) and the crate2nix-zos approach of declaring all build inputs locally.
The activation script for /etc files uses fs::canonicalize to resolve all paths when scanning the static environment. This causes the activation to fail with a 'No such file or directory' error if it encounters a broken symlink. This can happen if a Nix module generates a path to a subdirectory of a package that doesn't exist (e.g., /lib/tmpfiles.d), resulting in a broken link in the symlinkJoin that creates the /etc static environment. This patch makes the activation script more resilient by checking for and skipping broken or unreadable symlinks, logging a warning instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves an activation failure caused by broken symlinks in the /etc static
environment, often triggered by tmpfiles.d configurations. The activation script now warns and skips broken links instead of crashing.