-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(try): update starter selection for expanded 0.114 catalog #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
9fdd94c
refactor(setup nu): replace action flags with subcommands + shared co…
tonythethompson 633c50c
fix: 3 findings — Prevent PATH subcommand from deleting active managed N
qodo-code-review[bot] fb0ff23
fix: address PR #66 review feedback
tonythethompson 438d80b
fix: clarify PATH messaging in Nu setup hints
tonythethompson 7e726a2
Add reserved `numan use` CLI stub
tonythethompson 7951797
fix: apply CodeRabbit auto-fixes
coderabbitai[bot] 8062a11
feat: implement numan use for side-by-side Nu version management
tonythethompson 213e874
fix: 5 findings — Validate and normalize Nu versions; Propagate legacy m
qodo-code-review[bot] b8f4233
fix: address PR review — validate before delete, fix help text, fix c…
tonythethompson 62b8656
chore: remove temp files
tonythethompson 2591036
Update src/cmd/snapshot.rs
tonythethompson d9b8e0f
fix: PR 67 review - bootstrap yes flag, version check, mutation lock
tonythethompson 0429557
Merge origin/master into feature/numan-use - resolve conflicts: take …
tonythethompson e245232
Update .gitignore
tonythethompson 641bd24
wip(numan-use): integrate use + migration pieces (split pending)
tonythethompson e0e467e
feat(nu): extract legacy migrate fs + tests into src/nu/migrate_legacy
tonythethompson a006204
fix: Reconcile migration journal under lock
qodo-code-review[bot] 10b4e31
fix: Recover prepared migrations from filesystem state
qodo-code-review[bot] 7153a7f
fix: Remove redundant migration comment
qodo-code-review[bot] 283a1c4
fix: Keep use list read-only
qodo-code-review[bot] 45846fc
Potential fix for pull request finding
tonythethompson 6679cc3
Potential fix for pull request finding
tonythethompson 01c0e44
Update src/cmd/setup.rs
tonythethompson da3daec
Update src/nu/bootstrap.rs
tonythethompson 2635dbd
Update src/state/migration_journal.rs
tonythethompson d52cda6
Update src/nu/version_manager.rs
tonythethompson d0a5c27
Update src/nu/migrate_legacy.rs
tonythethompson db0cbb0
Merge branch 'master' into pr-migrate-legacy-installs
tonythethompson a867a90
fix(migrate): address PR 69 unresolved review threads (8 fixes)
tonythethompson 5bbdaf5
fix(migrate): rebase fallout — close stray fn, drop unused imports, g…
tonythethompson 0e8863e
docs(agents): list nu/migrate_legacy.rs in the project structure
tonythethompson 323fcb3
fix(migrate): address PR 69 remaining review threads (7 fixes)
tonythethompson 5705910
refactor(setup): route setup_subcommand_lock across destructive setup…
tonythethompson e14959f
refactor(setup): require_tty_or_yes seam + apply across all destructi…
tonythethompson 44381ff
feat(setup): --force flag for `setup nu use <path>` opt-in to destruc…
tonythethompson 81ac8ee
fix: 4 findings — Lock direct setup execution; Fix setup test arguments;
qodo-code-review[bot] 471347c
fix: Include legacy installs in version listing
qodo-code-review[bot] cea6efd
fix(migrate): install into versioned layout (PR69 Srm) + versioned-la…
tonythethompson ce81a65
audit(destructive): require_tty_or_yes for remove and snapshot delete…
tonythethompson 2682b97
Update migrate_legacy.rs
tonythethompson 225dc72
Merge origin/master into feature/setup-subcommand-lock
cursoragent bfa9ac3
Fix PR #71 review: version-before-mutation and force gates
cursoragent 302d5b6
Fix PR #71 review: TTY seams, migration safety, marker order
tonythethompson 8b8b1cd
Fix rustfmt in migrate_legacy regression test
tonythethompson 3b655fb
fix(nu): return VersionManagerError from public version APIs
cursoragent 8f009ff
Fix PR #71 review: docs, doctor hints, detect timeout
tonythethompson 85dcc8c
Fix PR #71 review: PATH test mutex and clear-before-delete
tonythethompson 438f695
fix(pr71): hoist migration symlink guard and cover use snapshots
cursoragent 58bd10d
Fix cubic PR #71: corrupt marker, list migration, ignore gates
tonythethompson 9079553
Fix Copilot review: gate use-latest off-tree preservation
tonythethompson 2fd31e9
Fix Codex review: refresh Nu paths cache on version switch
tonythethompson fa60c64
Fix macOS Real-Nu PATH race in setup_nu_test
tonythethompson f157121
Fix PathRestoreGuard doctest under --ignored
tonythethompson 75cd2ce
Fix setup nu short-circuit on dangling active marker
tonythethompson 5e40ef6
Merge master into feature/setup-subcommand-lock
tonythethompson d24f79a
docs(roadmap): audit each Post-1.0 claim against shipped code
tonythethompson 248e333
feat(roadmap-contract): freeze the cross-repo guardrail at numan-road…
tonythethompson f79ad65
fix(roadmap-contract): align CONTRACT_SHA with the v1 tag's resolved SHA
tonythethompson 8092f97
fix(ci): drop CONTRACT_SHA verify in favor of tag-existence check
tonythethompson be59965
fix(roadmap-contract): correct bump tag math and mirror v1 SHA pin
cursoragent 377b258
fix(roadmap-contract): address Cubic/CodeRabbit PR 72 findings
cursoragent 163a140
chore: retarget roadmap contract v1 pin to 60a015fec1b2
cursoragent 59554fa
Potential fix for pull request finding
tonythethompson c9637ba
ci(roadmap-drift): authenticate GitHub API verify step
tonythethompson 4dbf830
feat(try): update starter selection for expanded 0.114 catalog
tonythethompson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Fix the YAML block-scalar indentation in all roadmap workflows.
The Python source starts at YAML column zero. This ends the
run: |scalar and makes each workflow invalid YAML. None of the contract validation jobs can load..github/workflows/ci.yml#L75-L96: indent the embedded Python program and its closing quote within therun: |scalar.cross-repo-mirror/numan-plugins/.github/workflows/roadmap-drift.yml#L33-L54: indent the embedded Python program and its closing quote within therun: |scalar.cross-repo-mirror/numan-registry/.github/workflows/roadmap-drift.yml#L33-L54: indent the embedded Python program and its closing quote within therun: |scalar.🧰 Tools
🪛 actionlint (1.7.12)
[error] 81-81: could not parse as YAML: could not find expected ':'
(syntax-check)
🪛 YAMLlint (1.37.1)
[error] 82-82: syntax error: could not find expected ':'
(syntax)
📍 Affects 3 files
.github/workflows/ci.yml#L75-L96(this comment)cross-repo-mirror/numan-plugins/.github/workflows/roadmap-drift.yml#L33-L54cross-repo-mirror/numan-registry/.github/workflows/roadmap-drift.yml#L33-L54🤖 Prompt for AI Agents
Source: Linters/SAST tools