Add Linux ARM formula support with pre-ARM legacy mode - #5
Merged
Conversation
Sync the vendored renderer with numan's aarch64-unknown-linux-gnu bottle stanza, keep Formula/numan.rb on v0.2.1 until that archive ships, and teach update/check workflows to use --legacy-pre-linux-arm.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares this Homebrew tap to support future Linux ARM (aarch64-unknown-linux-gnu) bottle URLs while preserving a legacy mode for pre-Linux-ARM releases/tags.
Changes:
- Extend the formula renderer to parse/render Linux ARM digests, with
--legacy-pre-linux-armto allow older releases without Linux ARM assets. - Update unit tests and the formula roundtrip checker to handle the optional/legacy Linux ARM asset presence.
- Adjust the update workflow and README to reflect Linux ARM being optional until assets exist.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/render_homebrew_formula.py | Adds Linux ARM asset support and a legacy flag controlling required assets and rendered Linux ARM stanza. |
| scripts/test_render_homebrew_formula.py | Expands coverage for Linux ARM parsing/rendering and legacy behavior. |
| scripts/check_formula.py | Updates invariant checks and roundtrip rendering to tolerate pre-Linux-ARM releases. |
| .github/workflows/update-formula.yml | Adds conditional legacy rendering based on whether the Linux ARM asset exists on the release. |
| README.md | Documents platform support status and legacy rendering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares this tap for Linux ARM (
aarch64-unknown-linux-gnu) bottle URLs once numan publishes that archive (see numan-cli/numan#99).Changes
scripts/render_homebrew_formula.pywith Linux ARM +--legacy-pre-linux-armcheck_formula.pyroundtrip for pre-ARM SHA256SUMSupdate-formula.ymlonly requires Linux ARM when the release asset existsFormula/numan.rbstays on v0.2.1 (macOS ARM + Linux x86_64). Digests and theon_linux/on_armstanza update automatically on the next ARM-enabled numan release.Test plan
python3 -m unittest scripts.test_render_homebrew_formula -vpython3 scripts/check_formula.py(network roundtrip + Linux archive layout)