Fix lock icons with visibility check#489
Merged
Merged
Conversation
Contributor
|
Good catch, let's fix this in transcription results too: https://github.com/nulib/dc-nextjs/blob/deploy/staging/components/Search/TranscriptionResults.tsx#L83 |
Contributor
Author
|
@kdid if you search for "chicago" in the deployed preview branch there's results with mixed visibility for testing: |
kdid
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes intermittent lock icons appearing on public search result thumbnails by checking item visibility before user scope state. Public items now render as unrestricted even if auth resolves without a user, while non-public items still respect loading state and matching read scopes.
Changes
Testing