Repository navigation
NamedFile: send Content-Length on 206 Partial Content - #40
Merged
Merged
Conversation
A 206 response to a Range request had no Content-Length. It now carries the length of the selected range, for GET and HEAD.
4 tasks done
fafhrd91
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client asks
ntex-filesfor part of a file with aRangeheader, the206 Partial Contentresponse has noContent-Length.What changes
206response to aGETwithRangecarriesContent-Lengthequal to the length of the selected range (11forbytes=10-20,21forbytes=0-20) and noTransfer-Encoding(test: test_named_file_content_length_headers).206response to aHEADwithRangecarriesContent-Lengthequal to the length of the selected range (11forbytes=10-20) and noTransfer-Encoding(test: test_head_content_length_headers).Reference
actix-files fixed the same in actix/actix-web#1496.
This PR can be merged independently of the others.