Skip to content

Fix collision errors when introducing history plugin after the fact#991

Open
tarzan wants to merge 4 commits into
norman:masterfrom
tarzan:fix-migration-errors
Open

Fix collision errors when introducing history plugin after the fact#991
tarzan wants to merge 4 commits into
norman:masterfrom
tarzan:fix-migration-errors

Conversation

@tarzan

@tarzan tarzan commented Mar 30, 2022

Copy link
Copy Markdown

I've redone the work of #850

The problem that still exists in this current version is:

  1. implement the friendly_id slugs
  2. figuring out somewhere along the line that you want the history plugin as well
  3. create a new sluggable record that would translate to an already existing slug
  4. fails with a database constraint on unique slugs

The method 'scope_for_slug_generator' did a bit too much work with an inner join that made existing records with no entry in the history table being filtered out.

@stale

This comment was marked as resolved.

@stale stale Bot added the stale label Jul 10, 2022
@parndt parndt added the pinned label Jul 21, 2022
@parndt

parndt commented Jul 21, 2022

Copy link
Copy Markdown
Collaborator

Thank you for redoing this @tarzan 😄

@stale stale Bot removed the stale label Jul 28, 2022
@tarzan

tarzan commented Oct 18, 2022

Copy link
Copy Markdown
Author

Thank you for redoing this @tarzan 😄

Before this becoming stale again: anything keeping you from merging this?

@parndt

parndt commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

I think it's good @tarzan

@norman can you think of any gotchas here? I've not used the history plugin before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants