Repository navigation
Add pattern: Approval-Bound Transactional Write - #160
Merged
nibzard merged 3 commits intoOct 14, 2026
Merged
Conversation
|
@Val1-IT is attempting to deploy a commit to the nkkko's projects Team on Vercel. A member of the Team first needs to authorize it. |
The related front-matter cited human-in-the-loop-approval-framework; the pattern's slug is human-in-loop-approval-framework. Co-Authored-By: Claude Code <noreply@anthropic.com>
Rebuild generated aggregates after rebasing onto current main. bun run build:data output. Co-Authored-By: Claude Code <noreply@anthropic.com>
nibzard
force-pushed
the
add-approval-bound-transactional-write
branch
from
October 14, 2026 22:45
fc32b76 to
6101a9c
Compare
Owner
|
Merged, with two small fixes on top: regenerated the catalog data (the PR was missing the 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR intent
Reviewer checklist
Notes
Adds patterns/approval-bound-transactional-write.md under Reliability & Eval.
It sits next to human-in-loop-approval-framework but covers a different part: binding the approval to one plan version, checking for drift, and committing the write, the postcondition check and the idempotency key in one transaction, so a resumed or retried run can't apply the change twice.
Conflict of interest: I maintain LedgerGuard, which is listed as one reference and disclosed in both
based_onand References. The primary source is Brandur Leach's idempotency-keys write-up. The other references are Will Chan, the Postgres docs, and two public agent-framework issues where this bug shows up. Status isemerging, not anything stronger.Why I think it's new here: the existing approval and plan patterns stop at "a human said yes". The failure this one handles happens after that: the approved run gets resumed or retried and the write lands twice, or lands on a row that changed after approval. Both linked framework issues are that bug.
External links are github.com, postgresql.org and two independent technical write-ups (brandur.org, willchan.me). No vendor links.