QuickJS: fix compilation and initialization - #1114
Closed
bnoordhuis wants to merge 2 commits into
Closed
Conversation
QuickJS 0.16.0 adds support for externally managed resizable arraybuffers, with a concomitant change to the function prototype of JS_NewArrayBuffer(). Add a configure check and use the new prototype when available. Fixes: nginx#1113 Refs: quickjs-ng/quickjs#1668
It causes JSContext initialization failures with QuickJS-NG 0.16.0 and up.
|
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree: I have hereby read the F5 CLA and agree to its terms You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This was referenced Aug 16, 2026
Contributor
|
Thank you, I am working on it in #1115. |
github-project-automation
Bot
moved this from New
to Done
in NGINX OSS Unified Workspace
Author
|
I have hereby read the F5 CLA and agree to its terms ...silly though it is. Forgot to mention: njs uncovered a bug in quickjs-ng itself that quickjs-ng/quickjs#1670 fixes. In no-assert builds the bug turns into a minor memory leak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113 and references quickjs-ng/quickjs#1668. Description in the commit logs. The QuickJS-NG build now compiles again and passes
make test.CONTRIBUTINGdocument