Skip to content

Tests: HTTP/3 reserved frame type on a request stream #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tahmid-23 wants to merge 1 commit into
base: master
Choose a base branch
from
+57 −1
Open

Tests: HTTP/3 reserved frame type on a request stream #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion h3_request_body.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ select STDERR; $| = 1;
select STDOUT; $| = 1;

my $t = Test::Nginx->new()->has(qw/http http_v3 proxy cryptx/)
->has_daemon('openssl')->plan(30);
->has_daemon('openssl')->plan(34);

$t->write_file_expand('nginx.conf', <<'EOF');

Expand Down Expand Up @@ -136,6 +136,49 @@ is(read_body_file($frame->{headers}->{'x-body-file'}), 'TESTMOREDATA',
is($frame->{headers}->{'x-length'}, 12,
'request body in multiple frames separately - content length');

# reserved frame with a payload after the body

$s = Test::Nginx::HTTP3->new();
$sid = $s->new_stream({ path => '/proxy/t.html', body_more => 1,
body => 'TEST' });
$s->h3_frame(0x1f * 42 + 0x21, 'grease', $sid);
$frames = $s->read(all => [{ sid => $sid, fin => 1 }]);

($frame) = grep { $_->{type} eq "HEADERS" } @$frames;
is($frame->{headers}->{':status'}, 200, 'reserved frame - status');
is(read_body_file($frame->{headers}->{'x-body-file'}), 'TEST',
'reserved frame - body');

# reserved frame between two DATA frames

$s = Test::Nginx::HTTP3->new();
$sid = $s->new_stream({ body_more => 1, headers => [
{ name => ':method', value => 'GET' },
{ name => ':scheme', value => 'http' },
{ name => ':path', value => '/proxy/t.html' },
{ name => ':authority', value => 'localhost' },
{ name => 'content-length', value => '8' }]});
$s->h3_body('TEST', $sid, { body_more => 1 });
$s->h3_frame(0x1f * 42 + 0x21, 'grease', $sid, { body_more => 1 });
$s->h3_body('MORE', $sid);
$frames = $s->read(all => [{ sid => $sid, fin => 1 }]);

($frame) = grep { $_->{type} eq "HEADERS" } @$frames;
is(read_body_file($frame->{headers}->{'x-body-file'}), 'TESTMORE',
'reserved frame between data - body');

# reserved frame with an empty payload

$s = Test::Nginx::HTTP3->new();
$sid = $s->new_stream({ path => '/proxy/t.html', body_more => 1,
body => 'TEST' });
$s->h3_frame(0x1f * 42 + 0x21, '', $sid);
$frames = $s->read(all => [{ sid => $sid, fin => 1 }]);

($frame) = grep { $_->{type} eq "HEADERS" } @$frames;
is(read_body_file($frame->{headers}->{'x-body-file'}), 'TEST',
'reserved frame empty - body');

# request body with an empty DATA frame

$s = Test::Nginx::HTTP3->new();
Expand Down
13 changes: 13 additions & 0 deletions lib/Test/Nginx/HTTP3.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,19 @@ sub pack_body {
$buf .= $body;
}

sub h3_frame {
my ($self, $type, $body, $sid, $extra) = @_;

$body = '' unless defined $body;
my $buf = build_int($type) . build_int(length($body)) . $body;

my $offset = $extra->{offset} || $self->{streams}{$sid}{sent};

$self->{streams}{$sid}{sent} += length($buf);
$self->raw_write($self->build_stream($buf,
start => $extra->{body_more}, sid => $sid, offset => $offset));
}

sub h3_max_data {
my ($self, $val, $stream) = @_;

Expand Down