[codex] Tests: cover client_max_body_size on chunked discard path - #108
Open
maxvanamersfort wants to merge 1 commit into
Open
[codex] Tests: cover client_max_body_size on chunked discard path#108maxvanamersfort wants to merge 1 commit into
maxvanamersfort wants to merge 1 commit into
Conversation
maxvanamersfort
marked this pull request as ready for review
August 24, 2026 14:19
sbhowmikf5
self-requested a review
August 26, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add regression coverage for nginx issue #1522 and companion source PR
nginx/nginx#1688.
The tests cover a discarded chunked request body:
client_max_body_sizeacross multiple chunks;Red-to-green result
Against nginx baseline
3f6f7824d4e2eb1ac37dec76683d525ac0ff521c, thetwo over-limit assertions fail because nginx returns 200 instead of 413.
Against the companion source patch, all 23 assertions in
body_chunked.tpass. The broader
body.t,body_chunked.t, andhttp_keepalive.trun alsopasses all 63 tests, with two pre-existing TODO assertions remaining TODO.
Related issue: nginx/nginx#1522