Skip to content

Tests: ngx_http_json_module tests. - #101

Open
roman-f5 wants to merge 1 commit into
nginx:masterfrom
roman-f5:dev/json-parser
Open

Tests: ngx_http_json_module tests.#101
roman-f5 wants to merge 1 commit into
nginx:masterfrom
roman-f5:dev/json-parser

Conversation

@roman-f5

@roman-f5 roman-f5 commented Aug 12, 2026

Copy link
Copy Markdown

Proposed changes

Added json_parser.t covering json_set value extraction (scalars, nested
objects and arrays, compound containers, literals, number types, escapes,
the '$' root selector, source caching, last-match-wins on duplicate keys,
quoted key segments, and binary-safe / Unicode / surrogate-pair keys), and
json_parser_invalid.t covering rejection of malformed json_set paths at
configuration load.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@roman-f5
roman-f5 requested a review from pluknet August 12, 2026 20:13
@roman-f5
roman-f5 force-pushed the dev/json-parser branch 3 times, most recently from 347aa85 to 02a6707 Compare August 12, 2026 22:54
@sindhushiv sindhushiv moved this from New to In Review in NGINX OSS Unified Workspace Aug 13, 2026
@roman-f5
roman-f5 force-pushed the dev/json-parser branch 5 times, most recently from 6284bcb to f6ba9ea Compare August 18, 2026 18:39
Comment thread json_parser.t Outdated
Comment thread json_parser.t
Comment thread json_parser.t
Comment thread json_parser.t
Comment thread json_parser.t
Comment thread json_parser.t Outdated
Comment thread json_parser.t Outdated
Comment thread json_parser.t
Comment thread json_parser.t Outdated
Comment thread json_parser.t
Comment thread json_parser.t
Comment thread json_parser.t Outdated
Comment thread json_parser.t
Comment thread json_parser.t Outdated
@dekobon

dekobon commented Aug 20, 2026

Copy link
Copy Markdown

The PR description no longer matches the diff: it says there is a separate json_parser_invalid.t file, but this PR only adds json_parser.t, and it lists $ root selector extraction even though the test correctly asserts that $ is rejected.

Could the description be updated to match the current coverage?

@route443 route443 removed their assignment Aug 28, 2026
@route443
route443 self-requested a review August 28, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

4 participants