Skip to content

Fix params block breaking piped operators in the entry workflow #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bentsherman wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −1
Open

Fix params block breaking piped operators in the entry workflow #7405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/nf-lang/src/main/java/nextflow/script/control/VariableScopeVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ public void visitParamV1(ParamNodeV1 node) {
public void visitWorkflow(WorkflowNode node) {
var classScope = workflowDsl(node.isEntry());
if( node.isEntry() && paramsType != null ) {
classScope = new ClassNode(classScope.getTypeClass());
var paramsMethod = classScope.getDeclaredMethods("getParams").get(0);
paramsMethod.setReturnType(paramsType);
}
Expand Down
17 changes: 17 additions & 0 deletions modules/nf-lang/src/test/groovy/nextflow/script/control/ScriptResolveTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,4 +534,21 @@ class ScriptResolveTest extends Specification {
deleteDir(root)
}

def 'should resolve piped operators in the entry workflow with a params block' () {
when:
def errors = check(
'''\
params {
greeting: String = 'hello'
}

workflow {
channel.of(1, 2) | view
}
'''
)
then:
errors.size() == 0
}

}
Loading