Skip to content

report: make name field optional - #615

Merged
sunshowers merged 1 commit into
nextest-rs:mainfrom
nikstur:report-without-name
Sep 10, 2026
Merged

sunshowers merged 1 commit into
nextest-rs:mainfrom
nikstur:report-without-name

Conversation

@nikstur

@nikstur nikstur commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Some tools, notably junit-xml from the Python ecosystem do not allow the user to add the name attribute to a report. quick-junit thus fails to parse junit.xml files generated with this library.

The XSD from the linked Jenkins junit docs also does not list the name for the Report as a required field.

This change makes quick-junit a little more compatible with the ecosystem.

@codecov

codecov Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.13%. Comparing base (2c3a158) to head (0f7e476).

Files with missing lines Patch % Lines
crates/quick-junit/src/serialize.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   85.09%   84.13%   -0.96%     
==========================================
  Files           7        7              
  Lines        1831     1721     -110     
==========================================
- Hits         1558     1448     -110     
  Misses        273      273              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sunshowers sunshowers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nikstur
nikstur force-pushed the report-without-name branch from 520ec60 to 39b1984 Compare August 25, 2026 19:30
@nikstur

nikstur commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@sunshowers anything more you want me to do?

Comment thread .pre-commit-config.yaml Resolved
Some tools, notably junit-xml from the Python ecosystem do not allow the
user to add the name attribute to a report. quick-junit thus fails to
parse junit.xml files generated with this library.

The XSD from the linked Jenkins junit docs also does not list the name
for the Report as a required field.

This change makes quick-junit a little more compatible with the
ecosystem.
@nikstur
nikstur force-pushed the report-without-name branch from 39b1984 to 0f7e476 Compare September 5, 2026 14:04
@sunshowers

Copy link
Copy Markdown
Member

Thanks!

@sunshowers
sunshowers merged commit fa1285e into nextest-rs:main Sep 10, 2026
11 checks passed
@sunshowers

Copy link
Copy Markdown
Member

Released in quick-junit 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants