fix(signaling): rejoin with a fresh session on 'no_such_room' rejection#18524
Open
Antreesy wants to merge 1 commit into
Open
fix(signaling): rejoin with a fresh session on 'no_such_room' rejection#18524Antreesy wants to merge 1 commit into
Antreesy wants to merge 1 commit into
Conversation
- When client reconnect to HPB after a network change, both HPB and PHP sessions might be expired - HPB opens a new websocket gracefully, but nothing triggers PHP session to be established again - HPB then rejects the room join with a "no_such_room" error. - Handle by dispatching server request to join conversation similar to useActiveSession.js logic Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
βοΈ Resolves
Reproduction steps:
Results without this PR:
Results with this PR:
AI (if applicable)
Tasks:
ποΈ UI Checklist
π Checklist