Skip to content

feat(TopBar): add a search messages button#18417

Open
Jafetlch wants to merge 1 commit into
nextcloud:mainfrom
Jafetlch:feat/search-button-topbar
Open

feat(TopBar): add a search messages button#18417
Jafetlch wants to merge 1 commit into
nextcloud:mainfrom
Jafetlch:feat/search-button-topbar

Conversation

@Jafetlch

@Jafetlch Jafetlch commented Jun 23, 2026

Copy link
Copy Markdown

☑️ Resolves

The in-conversation message search is hard to find: the only way to reach it is through the right sidebar. This adds a search button to the conversation top bar that opens it directly.

While wiring the button I noticed showSidebar({ activeTab: 'search' }) landed on the participants tab, since 'search' is a content state and not a tab id. RightSidebar.handleUpdateActive now forwards 'search' to handleUpdateState('search').

The first version of this PR also bound Ctrl+F, removed after @Antreesy pointed out it is already taken by the conversation search in the left navigation.

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Developed with Claude Code (claude-opus-4-8), commit carries the Assisted-by trailer. Reviewed and verified on a local Nextcloud 34 + Talk stable34 instance.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
No search entry point in the chat view Search button in the top bar
Message search open with results

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
  • 🏗️ Changes to database schema — no
  • 🔖 New/changed API endpoints — no

@nickvergessen

Copy link
Copy Markdown
Member

Without looking at the code at all:

(search button visible in TopBar next to call button, sidebar opens to Search tab on click or Ctrl+F)

Please add screenshots to assist the review process

Also your commit is missing the DCO to confirm you did the changes and the license is okay:
https://github.com/nextcloud/server?tab=contributing-ov-file#sign-your-work

@Antreesy

Copy link
Copy Markdown
Contributor

Besides, Ctrl+F is already taken by conversations search in left navigation: 6fce2eb
It's more a matter of giving it priority higher than the global Unified search

@Jafetlch Jafetlch force-pushed the feat/search-button-topbar branch from 05a95c1 to a22d52d Compare July 2, 2026 04:50
@Jafetlch

Jafetlch commented Jul 2, 2026

Copy link
Copy Markdown
Author

Thanks for the feedback! I've updated the PR:

  • Removed the Ctrl+F shortcut — as @Antreesy pointed out it's already bound to the conversation search in the left navigation. The PR is now just the discoverable TopBar button.
  • Signed off the commit (DCO now passes).
  • Added screenshots to the description (@nickvergessen).

One thing worth a look during review: the button needed a small change in RightSidebar as well — handleUpdateActive now routes the 'search' value to handleUpdateState('search'). Without it, showSidebar({ activeTab: 'search' }) fell back to the participants tab instead of opening the message search. Verified end-to-end on a local Nextcloud 34 + Talk stable34 build.

Happy to adjust the button placement or the approach if you'd prefer a different one.

Add a magnify icon button to the TopBar that opens the message search
directly from the chat view. The button is only shown when the user is
authenticated, not in a call, and not in sidebar mode.

The message search (SearchMessagesTab) already exists but is only
reachable through the RightSidebar, which makes it hard to discover.
The button reuses the existing sidebarStore.showSidebar({ activeTab })
flow; RightSidebar.handleUpdateActive now routes the 'search' value to
handleUpdateState('search') so the sidebar opens straight on the search
view instead of falling back to the participants tab.

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Jafet Lopez <jafetlopezch@gmail.com>
@Jafetlch Jafetlch force-pushed the feat/search-button-topbar branch from a22d52d to 10f284a Compare July 2, 2026 15:58
@Jafetlch Jafetlch changed the title feat(TopBar): add search messages button and Ctrl+F / Cmd+F shortcut feat(TopBar): add a search messages button Jul 2, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants