feat(TopBar): add a search messages button#18417
Conversation
|
Without looking at the code at all:
Please add screenshots to assist the review process Also your commit is missing the DCO to confirm you did the changes and the license is okay: |
|
Besides, |
05a95c1 to
a22d52d
Compare
|
Thanks for the feedback! I've updated the PR:
One thing worth a look during review: the button needed a small change in Happy to adjust the button placement or the approach if you'd prefer a different one. |
Add a magnify icon button to the TopBar that opens the message search
directly from the chat view. The button is only shown when the user is
authenticated, not in a call, and not in sidebar mode.
The message search (SearchMessagesTab) already exists but is only
reachable through the RightSidebar, which makes it hard to discover.
The button reuses the existing sidebarStore.showSidebar({ activeTab })
flow; RightSidebar.handleUpdateActive now routes the 'search' value to
handleUpdateState('search') so the sidebar opens straight on the search
view instead of falling back to the participants tab.
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Jafet Lopez <jafetlopezch@gmail.com>
a22d52d to
10f284a
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
☑️ Resolves
The in-conversation message search is hard to find: the only way to reach it is through the right sidebar. This adds a search button to the conversation top bar that opens it directly.
While wiring the button I noticed
showSidebar({ activeTab: 'search' })landed on the participants tab, since'search'is a content state and not a tab id.RightSidebar.handleUpdateActivenow forwards'search'tohandleUpdateState('search').The first version of this PR also bound Ctrl+F, removed after @Antreesy pointed out it is already taken by the conversation search in the left navigation.
AI (if applicable)
Developed with Claude Code (claude-opus-4-8), commit carries the
Assisted-bytrailer. Reviewed and verified on a local Nextcloud 34 + Talk stable34 instance.🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist