Skip to content

[stable33] fix(files,files_sharing): swallow redirected navigation errors #59887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 2 commits into from
Jun 17, 2026
Merged

[stable33] fix(files,files_sharing): swallow redirected navigation errors #59887

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5592116
fix(files,files_sharing): swallow redirected navigation errors
solracsf Apr 22, 2026
32983ba
chore(assets): Recompile assets
nextcloud-command Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/files/src/router/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,14 @@ Router.prototype.replace = (function(this: Router, ...args: Parameters<typeof or
}) as typeof originalReplace

/**
* Ignore duplicated-navigation error but forward real exceptions
* Ignore duplicated- and redirected-navigation errors but forward real exceptions
*
* @param error The thrown error
*/
function ignoreDuplicateNavigation(error: unknown): void {
if (isNavigationFailure(error, NavigationFailureType.duplicated)) {
logger.debug('Ignoring duplicated navigation from vue-router', { error })
if (isNavigationFailure(error, NavigationFailureType.duplicated)
|| isNavigationFailure(error, NavigationFailureType.redirected)) {
logger.debug('Ignoring duplicated/redirected navigation from vue-router', { error })
} else {
throw error
}
Expand Down
7 changes: 4 additions & 3 deletions apps/files_sharing/src/router/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,14 @@ Router.prototype.replace = (function(this: Router, ...args: Parameters<typeof or
}) as typeof originalReplace

/**
* Ignore duplicated-navigation error but forward real exceptions
* Ignore duplicated- and redirected-navigation errors but forward real exceptions
*
* @param error The thrown error
*/
function ignoreDuplicateNavigation(error: unknown): void {
if (isNavigationFailure(error, NavigationFailureType.duplicated)) {
logger.debug('Ignoring duplicated navigation from vue-router', { error })
if (isNavigationFailure(error, NavigationFailureType.duplicated)
|| isNavigationFailure(error, NavigationFailureType.redirected)) {
logger.debug('Ignoring duplicated/redirected navigation from vue-router', { error })
} else {
throw error
}
Expand Down
Loading