Skip to content

Gui fix - #4363

Merged
marinofaggiana merged 4 commits into
masterfrom
Gui-fix
Oct 3, 2026
Merged

Gui fix#4363
marinofaggiana merged 4 commits into
masterfrom
Gui-fix

Conversation

@marinofaggiana

@marinofaggiana marinofaggiana commented Oct 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds an option to ignore previous entries in the local auto-upload history, allowing users to upload photos and videos again after deleting them from the server.

  • Available for both legacy and PhotoKit auto-upload. Successful uploads are still recorded, and files already uploaded during the current session remain excluded.
  • The option can only be changed while auto-upload is stopped. Existing server files may be overwritten when enabled.
  • Queue status now shows “files in queue” instead of implying a total number of remaining library items. PhotoKit shows “Automatic upload active” when its current queue is empty.
  • Prevent overlapping background auto-upload syncs triggered by refresh, processing and location tasks.
  • Improve album icon and date-picker spacing.
  • Preserve pending Live Photo playback when downloading its resources.
  • Bump the Realm schema version to 422.

Validation: SwiftLint and diff checks passed. Build and runtime verification are performed manually in Xcode.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@marinofaggiana
fix: preserve Live Photo playback request after download
40abfee 
Assisted-by: Codex:gpt-6
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: improve auto-upload album icon and date spacing
442a881 
Assisted-by: Codex:gpt-6
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: allow auto upload to ignore previous upload records
64eb5e6 
Persist the reupload option per account and track completed uploads by session to avoid repeatedly requeuing them. Apply the option to legacy and PhotoKit uploads and clarify that the displayed count represents queued files. Bump Realm schema to 422.

Assisted-by: Codex:GPT-6
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
marinofaggiana marked this pull request as draft October 3, 2026 07:57
@marinofaggiana marinofaggiana self-assigned this Oct 3, 2026
@marinofaggiana
fix: prevent overlapping auto upload background syncs
f66c142 
Guard the shared refresh, processing, and location entry point with a protected running flag. Release the flag on every exit without holding the lock across awaits.

Assisted-by: Codex:GPT-6
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
marinofaggiana marked this pull request as ready for review October 3, 2026 08:34
@marinofaggiana
marinofaggiana merged commit 3173216 into master Oct 3, 2026
9 checks passed
@marinofaggiana
marinofaggiana deleted the Gui-fix branch October 3, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpivchev mpivchev Awaiting requested review from mpivchev mpivchev is a code owner

Assignees

@marinofaggiana marinofaggiana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marinofaggiana