Fix: Live Photo restoration and Office routing, improve logs and notifications - #4354
Merged
Merged
Conversation
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Improve document MIME type matching, including generic server types, Apple type identifiers and optional editor formats. Restrict the HTML compatibility exception to Nextcloud Text. Extend “Open in Office” to available Collabora, OnlyOffice and EuroOffice editors, with a submenu when multiple editors are available. Keep the local PDF viewer as the default when tapping a PDF. Propagate editor errors instead of falling back to native preview or download. Preserve local preview for downloaded documents while offline. Add MIME type and editor compatibility regression tests. Validation: SwiftLint and project file checks passed. Builds, tests and Collabora/secure-view verification have not been run locally. Refs #4347. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
marinofaggiana
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve original Live Photo resources, improve Office editor routing, and update log management and notification loading.
Live Photos
Office documents
Logs and notifications
Validation
SwiftLint and project file checks passed for the Office routing changes. Builds and tests were not run locally. Device verification is still needed for Live Photo restoration, Office editors and secure-view documents.
Refs #2164 and #4347.
🤖 AI (if applicable)