Conversation
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
mpivchev
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused presentation changes are consistent across both playback implementations with no identified correctness issues.
Review effort: Balanced
Findings: None
What changed in this PR
Improves video-player control visibility across appearance modes and localizes VLC’s disabled-track option.
Changes:
- Uses adaptive system colors and material backgrounds.
- Adds clearer enabled-state icons.
- Localizes VLC’s “Disable” track label.
| File | Description |
|---|---|
NCVideoVLCViewController.swift |
Localizes disabled tracks. |
NCVideoVLCPresenter.swift |
Uses adaptive navigation colors. |
NCVideoPlaybackCoverView.swift |
Improves cover-control visibility. |
NCVideoControlsView.swift |
Updates control colors, materials, and state icons. |
NCVideoAVPlayerPresenter.swift |
Uses adaptive navigation colors. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove custom button styles and use native liquid glass.
Localizes some vlc strings