fix(auto-upload): reduce JPEG compression quality to 0.85 - #4288
Open
naelfe wants to merge 1 commit into
Open
Conversation
Quality 1.0 forces an inefficient encode and re-encodes the source HEIC's compression artifacts, roughly tripling the resulting file size with no visible gain. Fixes nextcloud#4287 Signed-off-by: naelfe <108142825+naelfe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality 1.0 forces an inefficient encode and re-encodes the source HEIC's compression artifacts, roughly tripling the resulting file size with no visible gain.
Fixes #4287
🤖 AI (if applicable)
Testing
Not built locally — no macOS machine available. Relying on CI.
The value 0.85 is a conservative pick; Apple's guidance suggests ~0.8 for
re-encodes of already-compressed sources:
https://developer.apple.com/forums/thread/793946
Scope: this is meant as a minimal fix so the regression stops shipping.
Happy to adjust the value if you'd prefer a different one. A user-facing
setting next to the compatibility-mode toggle would be a good follow-up,
but I'd rather leave that to a separate PR than expand this one.
Note on the AI Usage
The one-line edit was made by hand. AI assistance was used for research —
locating the regression via
git blame— and for drafting the issue andcommit text.