Skip to content

fix(discovery): check quota before upload (during discovery) - #9777

Open
solracsf wants to merge 2 commits into
masterfrom
checkQuotaBeforeUpload
Open

fix(discovery): check quota before upload (during discovery)#9777
solracsf wants to merge 2 commits into
masterfrom
checkQuotaBeforeUpload

fix: SonarCloud issues

ef71e47
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 27, 2026 in 1h 2m 36s

Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
105 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 2562 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce this switch case number of lines from 14 to at most 5, for example by extracting code into methods. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMysP&open=AZ-kFEDXwDoFqFPrMysP&pullRequest=9777

Check warning on line 63 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMyrf&open=AZ-kFEDXwDoFqFPrMyrf&pullRequest=9777

Check warning on line 2539 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "leadingAndTrailingSpacesFilesAllowed" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMysL&open=AZ-kFEDXwDoFqFPrMysL&pullRequest=9777

Check warning on line 278 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMyrp&open=AZ-kFEDXwDoFqFPrMyrp&pullRequest=9777

Check warning on line 512 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFDwAwDoFqFPrMyq0&open=AZ-kFDwAwDoFqFPrMyq0&pullRequest=9777

Check warning on line 724 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the assignment to "_original" from this expression. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFDwAwDoFqFPrMyq-&open=AZ-kFDwAwDoFqFPrMyq-&pullRequest=9777

Check warning on line 252 in src/libsync/discovery.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEHswDoFqFPrMysU&open=AZ-kFEHswDoFqFPrMysU&pullRequest=9777

Check warning on line 1367 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFDwAwDoFqFPrMyrQ&open=AZ-kFDwAwDoFqFPrMyrQ&pullRequest=9777

Check warning on line 787 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion from 'qint64' (aka 'long long') to 'double' may lose precision 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEJNwDoFqFPrMysV&open=AZ-kFEJNwDoFqFPrMysV&pullRequest=9777

Check failure on line 1081 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMyr0&open=AZ-kFEDXwDoFqFPrMyr0&pullRequest=9777

Check warning on line 724 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the assignment to "_target" from this expression. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFDwAwDoFqFPrMyrA&open=AZ-kFDwAwDoFqFPrMyrA&pullRequest=9777

Check failure on line 1665 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMyr4&open=AZ-kFEDXwDoFqFPrMyr4&pullRequest=9777

Check warning on line 1681 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "movePerms" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMyr3&open=AZ-kFEDXwDoFqFPrMyr3&pullRequest=9777

Check warning on line 477 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::lower_bound" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFDwAwDoFqFPrMyq4&open=AZ-kFDwAwDoFqFPrMyq4&pullRequest=9777

Check warning on line 1367 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "reliable" of type "_Bool" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFDwAwDoFqFPrMyrR&open=AZ-kFDwAwDoFqFPrMyrR&pullRequest=9777

Check warning on line 63 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "data" of type "class OCC::DiscoveryPhase *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMyrg&open=AZ-kFEDXwDoFqFPrMyrg&pullRequest=9777

Check warning on line 75 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "bytesSent" of type "long long" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEJNwDoFqFPrMysZ&open=AZ-kFEJNwDoFqFPrMysZ&pullRequest=9777

Check failure on line 2350 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 27 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMysJ&open=AZ-kFEDXwDoFqFPrMysJ&pullRequest=9777

Check failure on line 695 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMyrw&open=AZ-kFEDXwDoFqFPrMyrw&pullRequest=9777

Check warning on line 2534 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "excludeReason" of type "enum CSYNC_EXCLUDE_TYPE" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMysO&open=AZ-kFEDXwDoFqFPrMysO&pullRequest=9777

Check warning on line 2211 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Capture variables by reference, it is safe in this context. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMysI&open=AZ-kFEDXwDoFqFPrMysI&pullRequest=9777

Check warning on line 2213 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find_if" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMysH&open=AZ-kFEDXwDoFqFPrMysH&pullRequest=9777

Check warning on line 63 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "lastSyncTimestamp" of type "long long" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMyrj&open=AZ-kFEDXwDoFqFPrMyrj&pullRequest=9777

Check warning on line 33 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFEDXwDoFqFPrMyre&open=AZ-kFEDXwDoFqFPrMyre&pullRequest=9777

Check warning on line 1354 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this loop with a "std::erase_if" call. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-kFDwAwDoFqFPrMyrP&open=AZ-kFDwAwDoFqFPrMyrP&pullRequest=9777
View more details on SonarQubeCloud