(draft) fix: settings dialog is missing panel colors - #10524
Draft
Rello wants to merge 1 commit into
Draft
Conversation
- All settings panels now use platform-native QGroupBox rendering. - Navigation always uses the same QGroupBox wrapper. - Removed platform-specific panel colors and BACKGROUND_PALETTE. - No hardcoded surface colors were introduced. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Member
|
I mean I would definitely not ship Windows like this. The rest looks fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the current settings dialog does not render the colours and is white on white
different rendering on different platforms.
Proposal:
@kra-mo wdyt? the windows with the frames does not look perfect. but at least its not white/white. it does not use any hard coded colours but the "native" rendering fo the QGroupBox as a kind of compromise
Assisted-by: Codex:GPT-5
macOS:
Win:
