Skip to content

Feature/retry failed network requests - #10486

Open
mgallien wants to merge 2 commits into
masterfrom
feature/retryFailedNetworkRequests
Open

Feature/retry failed network requests#10486
mgallien wants to merge 2 commits into
masterfrom
feature/retryFailedNetworkRequests

feat(network): in case remote host closed the connection: retry once

ecc895f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 30, 2026 in 22m 56s

Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
16 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 285 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0uF2NhhPqB0kzTA&open=AZ-vB0uF2NhhPqB0kzTA&pullRequest=10486

Check warning on line 597 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "reply" is "class QNetworkReply *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0uF2NhhPqB0kzTB&open=AZ-vB0uF2NhhPqB0kzTB&pullRequest=10486

Check warning on line 124 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "requestBody" of type "class QIODevice *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0uF2NhhPqB0kzS-&open=AZ-vB0uF2NhhPqB0kzS-&pullRequest=10486

Check warning on line 597 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "reply" of type "class QNetworkReply *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0uF2NhhPqB0kzTC&open=AZ-vB0uF2NhhPqB0kzTC&pullRequest=10486

Check warning on line 123 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "req" of type "class QNetworkRequest" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0uF2NhhPqB0kzS9&open=AZ-vB0uF2NhhPqB0kzS9&pullRequest=10486

Check warning on line 213 in src/libsync/abstractnetworkjob.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0g92NhhPqB0kzS7&open=AZ-vB0g92NhhPqB0kzS7&pullRequest=10486

Check warning on line 38 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "reply" is "class QNetworkReply *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0vJ2NhhPqB0kzTD&open=AZ-vB0vJ2NhhPqB0kzTD&pullRequest=10486

Check warning on line 393 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0uF2NhhPqB0kzS8&open=AZ-vB0uF2NhhPqB0kzS8&pullRequest=10486

Check warning on line 38 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "reply" of type "class QNetworkReply *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0vJ2NhhPqB0kzTE&open=AZ-vB0vJ2NhhPqB0kzTE&pullRequest=10486

Check warning on line 79 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0vJ2NhhPqB0kzTK&open=AZ-vB0vJ2NhhPqB0kzTK&pullRequest=10486

Check warning on line 55 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "op" of type "enum QNetworkAccessManager::Operation" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0vJ2NhhPqB0kzTI&open=AZ-vB0vJ2NhhPqB0kzTI&pullRequest=10486

Check warning on line 55 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the redundant return type of this lambda. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0vJ2NhhPqB0kzTG&open=AZ-vB0vJ2NhhPqB0kzTG&pullRequest=10486

Check warning on line 38 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "authenticator" of type "class QAuthenticator *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0vJ2NhhPqB0kzTF&open=AZ-vB0vJ2NhhPqB0kzTF&pullRequest=10486

Check warning on line 55 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 27 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0vJ2NhhPqB0kzTH&open=AZ-vB0vJ2NhhPqB0kzTH&pullRequest=10486

Check failure on line 57 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0vJ2NhhPqB0kzTJ&open=AZ-vB0vJ2NhhPqB0kzTJ&pullRequest=10486

Check warning on line 137 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "req" of type "class QNetworkRequest" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ-vB0uF2NhhPqB0kzS_&open=AZ-vB0uF2NhhPqB0kzS_&pullRequest=10486
View more details on SonarQubeCloud