Skip to content

chore: cleanup some unused capability/sharing methods - #10348

Merged
nilsding merged 3 commits into
masterfrom
refactor/noid/remove-unused-sharing-methods
Jul 13, 2026
Merged

chore: cleanup some unused capability/sharing methods#10348
nilsding merged 3 commits into
masterfrom
refactor/noid/remove-unused-sharing-methods

chore(sharing): remove unused methods related to `name` attributes

cf6c0de
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 13, 2026 in 39m 34s

Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ A)
79 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 325 in src/gui/filedetails/sharemodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Using HTTP is insecure. Use HTTPS instead. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEUMjjr2Jzoybddr&open=AZ9LuEUMjjr2Jzoybddr&pullRequest=10348

Check warning on line 257 in src/gui/filedetails/sharemodel.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuESYjjr2Jzoybddg&open=AZ9LuESYjjr2Jzoybddg&pullRequest=10348

Check warning on line 571 in src/gui/filedetails/sharemodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested conditional operator into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEUMjjr2Jzoybddt&open=AZ9LuEUMjjr2Jzoybddt&pullRequest=10348

Check warning on line 1283 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "syncFolder" is "class OCC::Folder *const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEWRjjr2JzoybdeN&open=AZ9LuEWRjjr2JzoybdeN&pullRequest=10348

Check warning on line 477 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "folder" of type "class OCC::Folder *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEWRjjr2Jzoybdd6&open=AZ9LuEWRjjr2Jzoybdd6&pullRequest=10348

Check warning on line 384 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "data" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEDejjr2JzoybddP&open=AZ9LuEDejjr2JzoybddP&pullRequest=10348

Check warning on line 487 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "f" is "class OCC::Folder *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEWRjjr2Jzoybdd7&open=AZ9LuEWRjjr2Jzoybdd7&pullRequest=10348

Check warning on line 421 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEWRjjr2Jzoybdd4&open=AZ9LuEWRjjr2Jzoybdd4&pullRequest=10348

Check warning on line 637 in src/gui/filedetails/sharemodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEUMjjr2Jzoybddl&open=AZ9LuEUMjjr2Jzoybddl&pullRequest=10348

Check warning on line 1300 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a_cOFqB1O_tn3p8FW&open=AZ9a_cOFqB1O_tn3p8FW&pullRequest=10348

Check warning on line 662 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "sharee" of type "class QSharedPointer<class OCC::Sharee>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEDejjr2Jzoybddb&open=AZ9LuEDejjr2Jzoybddb&pullRequest=10348

Check warning on line 833 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "shareLabel" of type "class QString" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9atiDkVkfZGT2LvqD8&open=AZ9atiDkVkfZGT2LvqD8&pullRequest=10348

Check warning on line 1333 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEWRjjr2JzoybdeP&open=AZ9LuEWRjjr2JzoybdeP&pullRequest=10348

Check warning on line 1302 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "listener" is "class OCC::SocketListener *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a_cOFqB1O_tn3p8FY&open=AZ9a_cOFqB1O_tn3p8FY&pullRequest=10348

Check warning on line 554 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "shareType" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEDejjr2JzoybddZ&open=AZ9LuEDejjr2JzoybddZ&pullRequest=10348

Check warning on line 152 in src/gui/filedetails/sharemodel.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuESYjjr2Jzoybddf&open=AZ9LuESYjjr2Jzoybddf&pullRequest=10348

Check warning on line 761 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "data" of type "class QJsonObject" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEWRjjr2Jzoybdd-&open=AZ9LuEWRjjr2Jzoybdd-&pullRequest=10348

Check warning on line 287 in src/gui/filedetails/sharemodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEUMjjr2Jzoybddo&open=AZ9LuEUMjjr2Jzoybddo&pullRequest=10348

Check warning on line 781 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "fileData" of type "struct OCC::SocketApi::FileData" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a_cOFqB1O_tn3p8FU&open=AZ9a_cOFqB1O_tn3p8FU&pullRequest=10348

Check warning on line 587 in src/gui/filedetails/sharemodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEUMjjr2Jzoybddk&open=AZ9LuEUMjjr2Jzoybddk&pullRequest=10348

Check warning on line 1172 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "strings" of type "struct std::array<struct std::pair<const char *, class QString>, 7>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEWRjjr2JzoybdeG&open=AZ9LuEWRjjr2JzoybdeG&pullRequest=10348

Check warning on line 691 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEDejjr2Jzoybddd&open=AZ9LuEDejjr2Jzoybddd&pullRequest=10348

Check warning on line 434 in src/gui/sharemanager.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEX2jjr2JzoybdeR&open=AZ9LuEX2jjr2JzoybdeR&pullRequest=10348

Check warning on line 1300 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9a_cOFqB1O_tn3p8FX&open=AZ9a_cOFqB1O_tn3p8FX&pullRequest=10348

Check warning on line 484 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "folder" is "class OCC::Folder *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9LuEDejjr2JzoybddU&open=AZ9LuEDejjr2JzoybddU&pullRequest=10348
View more details on SonarQubeCloud