Skip to content

Add nextcloud-e2ee-verify: offline CLI validator for E2EE folder metadata - #10079

Open
mgallien with Copilot wants to merge 1 commit into
masterfrom
copilot/create-validation-tool-plan
Open

Add nextcloud-e2ee-verify: offline CLI validator for E2EE folder metadata#10079
mgallien with Copilot wants to merge 1 commit into
masterfrom
copilot/create-validation-tool-plan

Add nextcloud-e2ee-verify CLI tool for E2EE metadata validation

63aaffd
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 15, 2026 in 1h 12m 18s

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
53 New Code Smells (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)
12 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 132 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of nested "break" statements from 6 to 1 authorized. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJbQ&open=AZ5vmWqpK2pZvhKfqJbQ&pullRequest=10079

Check warning on line 556 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJbB&open=AZ5vmWqpK2pZvhKfqJbB&pullRequest=10079

Check warning on line 392 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJa-&open=AZ5vmWqpK2pZvhKfqJa-&pullRequest=10079

Check failure on line 557 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 35 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJbi&open=AZ5vmWqpK2pZvhKfqJbi&pullRequest=10079

Check warning on line 500 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJbA&open=AZ5vmWqpK2pZvhKfqJbA&pullRequest=10079

Check failure on line 474 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJbg&open=AZ5vmWqpK2pZvhKfqJbg&pullRequest=10079

Check warning on line 736 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstO&open=AZ50tEdv9EgPFv2mqstO&pullRequest=10079

Check warning on line 998 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove mixing of string literals with different encoding prefixes in this concatenation operation. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstn&open=AZ50tEdv9EgPFv2mqstn&pullRequest=10079

Check warning on line 1052 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove mixing of string literals with different encoding prefixes in this concatenation operation. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstp&open=AZ50tEdv9EgPFv2mqstp&pullRequest=10079

Check warning on line 673 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this range for-loop by "std::ranges::any_of". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJbk&open=AZ5vmWqpK2pZvhKfqJbk&pullRequest=10079

Check warning on line 125 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "ctx" of type "struct evp_cipher_ctx_st *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstR&open=AZ50tEdv9EgPFv2mqstR&pullRequest=10079

Check warning on line 750 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstP&open=AZ50tEdv9EgPFv2mqstP&pullRequest=10079

Check warning on line 770 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "cert" of type "struct x509_st *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstg&open=AZ50tEdv9EgPFv2mqstg&pullRequest=10079

Check warning on line 192 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJa6&open=AZ5vmWqpK2pZvhKfqJa6&pullRequest=10079

Check warning on line 428 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJa_&open=AZ5vmWqpK2pZvhKfqJa_&pullRequest=10079

Check warning on line 290 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "pkey" of type "struct evp_pkey_st *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstT&open=AZ50tEdv9EgPFv2mqstT&pullRequest=10079

Check warning on line 297 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "ctx" of type "struct evp_pkey_ctx_st *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstU&open=AZ50tEdv9EgPFv2mqstU&pullRequest=10079

Check warning on line 121 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'const int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJbF&open=AZ5vmWqpK2pZvhKfqJbF&pullRequest=10079

Check failure on line 165 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJbU&open=AZ5vmWqpK2pZvhKfqJbU&pullRequest=10079

Check warning on line 280 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJa8&open=AZ5vmWqpK2pZvhKfqJa8&pullRequest=10079

Check warning on line 286 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstN&open=AZ50tEdv9EgPFv2mqstN&pullRequest=10079

Check warning on line 900 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJbt&open=AZ5vmWqpK2pZvhKfqJbt&pullRequest=10079

Check warning on line 324 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "encPtr" of type "const unsigned char *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ5vmWqpK2pZvhKfqJba&open=AZ5vmWqpK2pZvhKfqJba&pullRequest=10079

Check warning on line 781 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "si" of type "struct CMS_SignerInfo_st *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqsth&open=AZ50tEdv9EgPFv2mqsth&pullRequest=10079

Check warning on line 838 in src/cmd/e2ee_verify_metadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove mixing of string literals with different encoding prefixes in this concatenation operation. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ50tEdv9EgPFv2mqstk&open=AZ50tEdv9EgPFv2mqstk&pullRequest=10079
View more details on SonarQubeCloud