feat: automatically create a teamfolder upon team creation - #2675
Open
stediefan wants to merge 3 commits into
Open
feat: automatically create a teamfolder upon team creation#2675stediefan wants to merge 3 commits into
stediefan wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
stediefan
force-pushed
the
feature/teams-auto-folder-creation
branch
2 times, most recently
from
July 24, 2026 09:47
eea615b to
a52e6da
Compare
7 tasks
CarlSchwan
reviewed
Jul 24, 2026
feat: introduce a function to upgrade existing teams to include the special teamfolder feat: add settings page to configure a default quota for new teamfolders Assisted by: GitHub Copilot:Claude Sonnet 5 Assisted by: GitHub Copilot:GPT-5.6 Terra Assisted by: GitHub Copilot:Kimi K2.7 Code Signed-off-by: Stefan Dietrich <5716289+stediefan@users.noreply.github.com>
stediefan
force-pushed
the
feature/teams-auto-folder-creation
branch
from
July 27, 2026 08:20
a52e6da to
6ab835a
Compare
artonge
reviewed
Jul 30, 2026
Signed-off-by: Stefan Dietrich <5716289+stediefan@users.noreply.github.com>
Signed-off-by: Stefan Dietrich <5716289+stediefan@users.noreply.github.com>
artonge
reviewed
Aug 4, 2026
| * | ||
| * Implementation: {@see TeamFolderPolicy} in the circles app. | ||
| */ | ||
| interface ITeamFolderPolicy { |
Contributor
There was a problem hiding this comment.
Do we expect multiple policy in the future? I am wondering wether we really need an interface
Comment on lines
+62
to
+63
| $hadEssentialKey = array_key_exists('team_folder_essential', $settings) | ||
| || array_key_exists('team_folder_id', $settings); |
Contributor
There was a problem hiding this comment.
I cannot find any reference of those settings. Are they really existing?
| ]]> | ||
| </description> | ||
| <version>35.0.0-dev.0</version> | ||
| <version>35.0.0-dev.1</version> |
Member
There was a problem hiding this comment.
I don't think we should handle this on on this PR, but rather upon release on a separate PR
| * maintain a second copy. | ||
| */ | ||
| class Version3500Date20260721000001 extends SimpleMigrationStep { | ||
| private const CFG_TEAM_FOLDER_LEGACY = 262144; |
Member
There was a problem hiding this comment.
maybe it would make more sense to declare this CFG const together with others on lib/Model/Circle? and also use the number increase pattern instead of just 262143 + 1?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: introduce a function to upgrade existing teams to include the special teamfolder
feat: add settings page to configure a default quota for new teamfolders
Assisted by: GitHub Copilot:Claude Sonnet 5
Assisted by: GitHub Copilot:GPT-5.6 Terra
Assisted by: GitHub Copilot:Kimi K2.7 Code
Summary
This is a aggregated feature that integrates teams with teamfolders. The teams feature aims to provide a space for team owned apps. This provides the base as the linked groupfolder is the proposed solution.
TODO
Checklist
The newly introduced feature to set a default Quota for the auto created folders:
see todo
no
3. to review, feature component)stable32)AI (if applicable)