Skip to content

fix: allways allow duplicaiton - #8689

Open
SebastianKrupinski wants to merge 1 commit into
mainfrom
fix/always-allow-duplication
Open

fix: allways allow duplicaiton#8689
SebastianKrupinski wants to merge 1 commit into
mainfrom
fix/always-allow-duplication

Conversation

@SebastianKrupinski

@SebastianKrupinski SebastianKrupinski commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Resolves: Allow to copy events #8608
  • Removed the isReadOnly (User should be able to duplicate any event, this is no different then exporting then importing)
  • Removed the canCreateRecurrenceException (This is used to control changing recurring events, so it makes no sense on duplication)
  • Fixed broken copy logic in copyCalendarObjectInstanceIntoEventComponent

@SebastianKrupinski SebastianKrupinski self-assigned this Aug 6, 2026
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Aug 6, 2026
@github-project-automation github-project-automation Bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Aug 6, 2026
@codecov

codecov Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/mixins/EditorMixin.js 0.00% 3 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

odzhychko
odzhychko requested changes Aug 6, 2026
View reviewed changes
Comment thread src/views/EditSimple.vue
Comment thread src/views/EditFull.vue
Comment thread src/views/EditFull.vue
@odzhychko odzhychko added Feature: Editor enhancement New feature request labels Aug 6, 2026
@odzhychko

odzhychko commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Found #8421 that implements duplication for read-only events.

@SebastianKrupinski
SebastianKrupinski force-pushed the fix/always-allow-duplication branch 2 times, most recently from 109d443 to 8e27ba0 Compare August 10, 2026 16:53
@SebastianKrupinski
fix: allways allow duplicaiton
b7c80d9 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/always-allow-duplication branch from 8e27ba0 to b7c80d9 Compare August 10, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov is a code owner
@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner
@odzhychko odzhychko Awaiting requested review from odzhychko

Requested changes must be addressed to merge this pull request.

Assignees

@SebastianKrupinski SebastianKrupinski

Labels

3. to review Waiting for reviews enhancement New feature request Feature: Editor

Projects

💌 📅 👥 Groupware team
Status: 🏗️ In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow to copy events

2 participants

@SebastianKrupinski @odzhychko