-
Notifications
You must be signed in to change notification settings - Fork 4
[NAE-2412] EnumerationMap, MultichoiceMap with 'caseref' component are editable on unassigned task #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/6.5.0
Are you sure you want to change the base?
[NAE-2412] EnumerationMap, MultichoiceMap with 'caseref' component are editable on unassigned task #330
Changes from 3 commits
2a31271
6d543ba
4d1a638
2bd1f60
620478e
6aa5158
dd06dcd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,7 @@ export abstract class AbstractHeaderModeComponent { | |
| @Input() public indeterminate: boolean; | ||
| @Input() public approvalFormControl: FormControl; | ||
| @Input() public typeApproval: string; | ||
| @Input() public disabled: boolean = false; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rename approval and rework to enum, and remove this disabled property |
||
|
|
||
| constructor() { | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import {Component, Input, Optional} from '@angular/core'; | ||
| import {Component,EventEmitter,Input,Optional,Output} from '@angular/core'; | ||
|
Check warning on line 1 in projects/netgrif-components-core/src/lib/panel/case-panel/abstract-case-panel.component.ts
|
||
| import {Observable} from 'rxjs'; | ||
| import {Case} from '../../resources/interface/case'; | ||
| import {toMoment} from '../../resources/types/nae-date-type'; | ||
|
|
@@ -38,6 +38,7 @@ | |
| @Input() showCasePanelIcon = true; | ||
| @Input() showDeleteMenu = false; | ||
| @Input() textEllipsis = false; | ||
| @Input() public disabled: boolean = false; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is replaced with enu, in previous comment |
||
| protected _approvalFormControl: FormControl; | ||
|
|
||
| protected constructor(protected _caseResourceService: CaseResourceService, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <div fxLayout="row" fxFlex="100" fxLayoutAlign="start center" class="netgrif-input netgrif-header-input netgrif-input-fix netgrif-zero-field-wrapper"> | ||
| <mat-checkbox *ngIf="approval && typeApproval === 'multichoice'" [formControl]="approvalFormControl" [indeterminate]="indeterminate" | ||
| (click)="$event.stopPropagation();" color='primary' class="checkbox-padding"></mat-checkbox> | ||
| (click)="$event.stopPropagation();" color='primary' class="checkbox-padding" [disabled]="disabled"></mat-checkbox> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. turn of the ripple if you change this to button |
||
| <mat-icon *ngIf="approval && typeApproval === 'enumeration'" color="warn" (click)="setValue();$event.stopPropagation();" class="checkbox-padding cursor-fix">close</mat-icon> | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| <mat-form-field *ngFor="let header of this.headerService.selectedHeaders$ | async; let i = index" fxLayout="row" | ||
| fxLayoutAlign=" center" fxFlex [ngStyle]="{'min-width': getMinWidth()}" appearance="outline" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename approval and rework to enum, and remove this disabled property