[NAE-2241] Anonymous access refactor #316
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| "enable": false, | ||
| "clientId": "dev-cluster-worker", | ||
| "redirectUrl": "http://localhost:8081/realms/netgrif-cloud-testing/protocol/openid-connect/auth", | ||
| "refreshUrl": "http://localhost:8080/api/auth/login", | ||
| "scopes": ["openid","email","profile","roles"] | ||
| } | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@netgrif/components-project", | ||
| "version": "7.0.0", | ||
| "description": "Netgrif Application Engine Frontend project. Project includes angular libraries as base for NAE applications.", | ||
| "homepage": "https://components.netgrif.com", | ||
| "license": "SEE LICENSE IN LICENSE", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ export class AppComponent { | |
| translate.setTranslation('en', en, true); | ||
| translate.setTranslation('sk', sk, true); | ||
|
|
||
| this.userService.user$.pipe(filter(u => !!u && u.id !== '' && !u.isAnonymous()), take(1)).subscribe(() => { | ||
| const allNets = allowedNetsFactory.createWithAllNets(); | ||
| allNets.allowedNetsIdentifiers$.pipe(take(1)).subscribe(nets => { | ||
| if (this.baseAllowedNets.allowedNets.length !== 0) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@netgrif/components-core", | ||
| "version": "7.0.0", | ||
| "description": "Netgrif Application engine frontend core Angular library", | ||
| "homepage": "https://components.netgrif.com", | ||
| "license": "SEE LICENSE IN LICENSE", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ import {ProxyAuthenticationService} from './proxyAuthentication.service'; | |
| import {AuthenticationMethodService} from './services/authentication-method.service'; | ||
| import {OverlayModule} from '@angular/cdk/overlay'; | ||
| import {MatProgressSpinnerModule} from '@angular/material/progress-spinner'; | ||
| // import {AnonymousAuthenticationInterceptor} from './services/anonymous-authentication-interceptor'; | ||
|
|
||
|
|
||
| @NgModule({ | ||
|
|
@@ -22,7 +22,7 @@ import {AnonymousAuthenticationInterceptor} from './services/anonymous-authentic | |
| ], | ||
| providers: [ | ||
| { provide: HTTP_INTERCEPTORS, useClass: AuthenticationInterceptor, multi: true }, | ||
| // { provide: HTTP_INTERCEPTORS, useClass: AnonymousAuthenticationInterceptor, multi: true }, | ||
| { provide: AuthenticationMethodService, useClass: ProxyAuthenticationService}, | ||
| // AuthenticationEffects | ||
| ] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -8,9 +8,7 @@ export * from './sign-up/public-api'; | |||
| /* MODULES */ | ||||
| export * from './authentication.module'; | ||||
|
|
||||
| // export * from './services/anonymous-authentication-interceptor' | ||||
|
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Remove the commented export from the public API surface. Keeping commented exports in a public API file creates dead code and ambiguity. If this export is intentionally retired, delete it outright. 🧹 Suggested cleanup-// export * from './services/anonymous-authentication-interceptor'📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||
| export * from './services/authentication-interceptor' | ||||
| export * from './proxyAuthentication.service' | ||||
|
|
||||
|
|
||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -11,15 +11,15 @@ import {Observable, throwError} from 'rxjs'; | |||
| import {catchError, tap} from 'rxjs/operators'; | ||||
| import {SessionService} from '../session/services/session.service'; | ||||
| import {RedirectService} from '../../routing/redirect-service/redirect.service'; | ||||
| // import {AnonymousService} from '../anonymous/anonymous.service'; | ||||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion | 🟠 Major Remove commented-out import. Delete the commented-out import rather than leaving dead code. If the ♻️ Proposed fix-// import {AnonymousService} from '../anonymous/anonymous.service';📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||
| import {SessionIdleTimerService} from "../session/services/session-idle-timer.service"; | ||||
|
|
||||
| @Injectable() | ||||
| export class AuthenticationInterceptor implements HttpInterceptor { | ||||
|
|
||||
| constructor(private _session: SessionService, | ||||
| private _redirect: RedirectService, | ||||
| // private _anonymousService: AnonymousService, | ||||
| private idleTimerService: SessionIdleTimerService) { | ||||
| } | ||||
|
Comment on lines
20
to
24
There was a problem hiding this comment. 🛠️ Refactor suggestion | 🟠 Major Remove commented-out constructor parameter. The commented-out ♻️ Proposed fix constructor(private _session: SessionService,
private _redirect: RedirectService,
- // private _anonymousService: AnonymousService,
private idleTimerService: SessionIdleTimerService) {
}🤖 Prompt for AI Agents |
||||
|
|
||||
|
|
@@ -37,7 +37,7 @@ export class AuthenticationInterceptor implements HttpInterceptor { | |||
| return next.handle(req).pipe( | ||||
| tap(event => { | ||||
| if (event instanceof HttpResponse) { | ||||
| if (event.headers.has(this._session.sessionHeader)) { | ||||
| this._session.setVerifiedToken(event.headers.get(this._session.sessionHeader)); | ||||
| } | ||||
| } | ||||
|
|
||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,7 @@ export class AccessService { | |
| if (view.access !== 'private') { | ||
| throw new Error(`Unknown access option '${view.access}'. Only 'public' or 'private' is allowed.`); | ||
| } | ||
| return !this._userService.user.isEmpty() && !this._userService.user.isAnonymous(); | ||
| } | ||
|
|
||
| if (!url) { | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove duplicate changelog entries.
The following entries appear twice in the 7.0.0 "Changed" section:
[NAE-1949]Allowed Types for Filefield — lines 48 and 56[NAE-2013]Autocomplete options are set to the first dropdown — lines 58 and 59[NAE-2085]Refactor User — lines 79 and 82Also applies to: 56-56, 58-59, 79-79, 82-82
🤖 Prompt for AI Agents