Fixes #22717: Correct Device Cluster Location validation#22725
Merged
arthanson merged 1 commit intoJul 21, 2026
Merged
Conversation
…error Changes 'site' to 'location' in the error message format string to match the actual parameter name being passed. Adds regression test coverage to verify the error message displays the correct location name. Fixes #22717
Contributor
Author
|
@claude /review Only report on issues of potential concern; we don't need commentary on anything that doesn't require further consideration. |
Contributor
|
Claude finished @pheus's task in 1m 24s —— View job No issues of concern found. The one-line fix correctly changes the format keyword argument from |
pheus
marked this pull request as ready for review
July 21, 2026 08:10
arthanson
approved these changes
Jul 21, 2026
arthanson
deleted the
22717-device-validation-raises-keyerror-when-assigned-cluster-is
branch
July 21, 2026 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #22717
Corrects device validation when its assigned cluster is scoped to a different location.
The validation message expects a
locationformatting argument, but the value was supplied using thesitekeyword. This caused aKeyErrorbefore the intended field validation error could be raised.Adds a regression test covering two locations within the same site and verifies the expected cluster validation message.