Skip to content

Declare react and react-dom peers on litform and litform-modals - #272

Merged
nbudin merged 1 commit into
mainfrom
fix-peer-dependencies
Nov 1, 2026
Merged

nbudin merged 1 commit into
mainfrom
fix-peer-dependencies

Conversation

@nbudin

@nbudin nbudin commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Declares the react / react-dom peer dependencies that two packages were missing, so consumers' package managers stop reporting unmet peer requirements for litform.

A consumer that installs @neinteractiveliterature/litform@0.36.0 currently gets (from Yarn 4's explain peer-requirements):

litform@0.36.0 doesn't provide react to litform-codemirror@0.36.0 and 7 other dependencies
litform@0.36.0 doesn't provide react-dom to litform-popovers@0.36.0 and 1 other dependency
litform-modals@0.36.0 doesn't provide react-dom to react-bootstrap4-modal@3.0.11
  • litform (the umbrella package): adds peerDependencies react >= 18 and react-dom >= 18. Its sub-packages, react-cool-onclickoutside, @floating-ui/react-dom and react-bootstrap4-modal all have peer requirements on those, and the umbrella is what the consumer installs, so it has to forward them. (Same ranges litform-popovers already declares.)
  • litform-modals: adds react-dom >= 18 as a peer (react-bootstrap4-modal 3 requires both; the package only declared react).
  • Matching react-dom (and, for the umbrella, react and react-dom) devDependencies so the monorepo's own install satisfies the new peers, as litform-popovers already does.

No code changes. These are all dependencies the packages already needed; this only makes the manifests say so.

Test plan

  • In a scratch consumer project, an install of the published 0.36.0 reproduces exactly the three complaints above; the same install with the umbrella and litform-modals replaced by packed builds of this branch reports none
  • In this workspace, yarn explain peer-requirements no longer lists the umbrella or litform-modals react/react-dom complaints (the remaining ones are dev tooling: Storybook, @testing-library, etc.)
  • ESLint clean; popovers and modals tests pass (30); litform and litform-modals build
  • CI

A patch release (0.36.1) would deliver this.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UKBUsxCfYBKFsYKKgN8Fsz

Both packages have dependencies that need react and react-dom (litform's sub-packages, react-cool-onclickoutside,
@floating-ui/react-dom and, for litform-modals, react-bootstrap4-modal), but only litform-popovers declared both.
Consumers' package managers reported them as unmet peer requirements:

  litform doesn't provide react to litform-codemirror and 7 other dependencies
  litform doesn't provide react-dom to litform-popovers and 1 other dependency
  litform-modals doesn't provide react-dom to react-bootstrap4-modal

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UKBUsxCfYBKFsYKKgN8Fsz
@nbudin nbudin added the patch label Nov 1, 2026
@nbudin
nbudin merged commit 4fa2f3c into main Nov 1, 2026
7 checks passed
@nbudin
nbudin deleted the fix-peer-dependencies branch November 1, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant