Repository navigation
Declare react and react-dom peers on litform and litform-modals - #272
Merged
Merged
Conversation
Both packages have dependencies that need react and react-dom (litform's sub-packages, react-cool-onclickoutside, @floating-ui/react-dom and, for litform-modals, react-bootstrap4-modal), but only litform-popovers declared both. Consumers' package managers reported them as unmet peer requirements: litform doesn't provide react to litform-codemirror and 7 other dependencies litform doesn't provide react-dom to litform-popovers and 1 other dependency litform-modals doesn't provide react-dom to react-bootstrap4-modal Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UKBUsxCfYBKFsYKKgN8Fsz
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declares the
react/react-dompeer dependencies that two packages were missing, so consumers' package managers stop reporting unmet peer requirements for litform.A consumer that installs
@neinteractiveliterature/litform@0.36.0currently gets (from Yarn 4'sexplain peer-requirements):litform(the umbrella package): addspeerDependenciesreact >= 18andreact-dom >= 18. Its sub-packages,react-cool-onclickoutside,@floating-ui/react-domandreact-bootstrap4-modalall have peer requirements on those, and the umbrella is what the consumer installs, so it has to forward them. (Same rangeslitform-popoversalready declares.)litform-modals: addsreact-dom >= 18as a peer (react-bootstrap4-modal3 requires both; the package only declaredreact).react-dom(and, for the umbrella,reactandreact-dom) devDependencies so the monorepo's own install satisfies the new peers, aslitform-popoversalready does.No code changes. These are all dependencies the packages already needed; this only makes the manifests say so.
Test plan
litform-modalsreplaced by packed builds of this branch reports noneyarn explain peer-requirementsno longer lists the umbrella orlitform-modalsreact/react-dom complaints (the remaining ones are dev tooling: Storybook,@testing-library, etc.)litformandlitform-modalsbuildA patch release (0.36.1) would deliver this.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UKBUsxCfYBKFsYKKgN8Fsz