Skip to content

Add tests for the modals restructured in #12089 - #12094

Merged
nbudin merged 3 commits into
mainfrom
test-modals-and-forward-email
Oct 5, 2026
Merged

Add tests for the modals restructured in #12089#12094
nbudin merged 3 commits into
mainfrom
test-modals-and-forward-email

Conversation

@nbudin

@nbudin nbudin commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

What

Tests for the four modals I restructured in #12089 without adding coverage (all were at 0%):

  • BecomeUserModal (identity assumption, so it's worth pinning down): the justification and bearer token that get sent, the redirect to / only on success, server errors and network failures keeping the modal open with the error shown, buttons disabled while in progress, no Authorization header without a token, no button without a profile.
  • CreateModeratedSignupModal: the conflicting-signup warning (and when it doesn't apply: no overlap, withdrawn, concurrent play), creating the request (with the signup to replace) or adding to the ranked-choice queue, errors from both branches, the missing-signup-option error.
  • NewFormItemModal: standard and custom items, items the form already has are disabled, the item-type choice for standard items that don't specify one, the identifier input and its reserved-identifier warning, creating the item, errors.
  • ConvertToEventProvidedTicketModal: needs an event and ticket type, offers only ticket types the event can provide (with remaining counts), converts, errors, in-progress state.

Small changes to make them testable

  • BecomeUserModal is now exported.
  • CreateModeratedSignupModal's run/event props are typed as Picks of the fields it uses (id, starts_at, length_seconds, can_play_concurrently). Callers pass richer objects, so nothing changes for them.

No behavior changes.

🤖 Generated with Claude Code

https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd

@nbudin @claude
Add tests for the modals restructured in the useAsyncFunction fix
b9e658d 
BecomeUserModal (sensitive: what gets sent, when it leaves the page),
CreateModeratedSignupModal, NewFormItemModal, and
ConvertToEventProvidedTicketModal, covering success, failure (the modal stays
open and shows the error), and in-progress states.

Two small changes to make them testable: BecomeUserModal is exported, and
CreateModeratedSignupModal's run/event props now ask only for the fields it uses
(callers pass richer objects, so nothing changes for them).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd
@nbudin nbudin added frontend tech debt patch Bumps the patch version number on release labels Oct 5, 2026
nbudin and others added 2 commits October 5, 2026 11:16
@nbudin @claude
Fix NewFormItemModal test fixture types
b08d588 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd
@nbudin @claude
Give the ConvertToEventProvidedTicketModal suspense waits a longer ti…
38142d9 
…meout

The ticket type section loads through a suspense query after an event is chosen;
on CI that took longer than testing-library's default one second once.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
app/controllers/application_controller.rb 🟢 75.21% 🟢 80.34% 🟢 5.13%
app/controllers/concerns/redirect_with_authentication.rb 🔴 0% 🔴 42.86% 🟢 42.86%
app/controllers/csv_exports_controller.rb 🔴 47.46% 🟢 100% 🟢 52.54%
app/controllers/graphql_controller.rb 🟢 86.05% 🟢 87.21% 🟢 1.16%
app/controllers/registrations_controller.rb 🔴 0% 🟢 85% 🟢 85%
app/controllers/reports_controller.rb 🔴 0% 🟢 80% 🟢 80%
app/controllers/stripe_account_controller.rb 🔴 0% 🟢 100% 🟢 100%
app/controllers/stripe_webhooks_controller.rb 🔴 0% 🟢 100% 🟢 100%
app/graphql/concerns/context_accessors.rb 🟢 90% 🟢 95% 🟢 5%
app/graphql/concerns/order_entry_inputs.rb 🔴 22.22% 🟢 88.89% 🟢 66.67%
app/graphql/concerns/scheduled_value_inputs.rb 🔴 28.57% 🟢 100% 🟢 71.43%
app/graphql/intercode_schema.rb 🟠 61.84% 🟢 85.53% 🟢 23.69%
app/graphql/money_helper.rb 🟠 60% 🟢 100% 🟢 40%
app/graphql/mutations/base_mutation.rb 🟢 81.03% 🟢 89.66% 🟢 8.63%
app/graphql/mutations/create_my_signup.rb 🟢 95.65% 🟢 84% 🔴 -11.65%
app/graphql/mutations/create_order.rb 🔴 35.71% 🟢 100% 🟢 64.29%
app/graphql/mutations/create_signup_ranked_choice.rb 🟠 68.42% 🟢 91.67% 🟢 23.25%
app/graphql/mutations/create_signup_request.rb 🟠 62.5% 🟢 90.48% 🟢 27.98%
app/graphql/mutations/create_user_con_profile.rb 🔴 32% 🟢 100% 🟢 68%
app/graphql/mutations/create_user_signup.rb 🟠 55.56% 🟢 93.1% 🟢 37.54%
app/graphql/mutations/merge_users.rb 🟠 50% 🟢 100% 🟢 50%
app/graphql/mutations/submit_order.rb 🟠 52.63% 🟢 100% 🟢 47.37%
app/graphql/mutations/update_convention.rb 🔴 30.43% 🟢 100% 🟢 69.57%
app/graphql/mutations/update_event.rb 🟢 92.11% 🟢 100% 🟢 7.89%
app/graphql/mutations/withdraw_user_signup.rb 🟠 60% 🟢 100% 🟢 40%
app/graphql/sources/active_storage_attachment.rb 🔴 0% 🟢 100% 🟢 100%
app/graphql/sources/signup_choice.rb 🔴 0% 🟢 100% 🟢 100%
app/graphql/sources/simulated_skip_reason.rb 🔴 0% 🟢 100% 🟢 100%
app/graphql/sources/waitlist_position.rb 🔴 0% 🟢 100% 🟢 100%
app/graphql/types/convention_type.rb 🟢 79.44% 🟢 81.18% 🟢 1.74%
app/graphql/types/date_type.rb 🟠 71.43% 🟢 100% 🟢 28.57%
app/graphql/types/event_type.rb 🟠 74.47% 🟢 75.26% 🟢 0.79%
app/graphql/types/grouped_signup_count_type.rb 🟢 85% 🟢 80% 🔴 -5%
app/graphql/types/json.rb 🟢 77.78% 🟢 88.89% 🟢 11.11%
app/helpers/reports_helper.rb 🔴 36.36% 🔴 45.45% 🟢 9.09%
app/javascript/Authentication/AccountFormContent.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Authentication/DeviseForgotPasswordPage.tsx 🔴 0% 🟢 85.19% 🟢 85.19%
app/javascript/Authentication/EditUser.tsx 🔴 0% 🟢 86.05% 🟢 86.05%
app/javascript/Authentication/PasswordConfirmationInput.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Authentication/PasswordInputWithStrengthCheck.tsx 🔴 0% 🟢 82.35% 🟢 82.35%
app/javascript/Authentication/ResetPassword.tsx 🔴 0% 🟢 96% 🟢 96%
app/javascript/Authentication/SignInButton.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Authentication/UserFormFields.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Authentication/authenticationManager.ts 🔴 16.33% 🟢 100% 🟢 83.67%
app/javascript/Authentication/queries.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/Authentication/useSignInContext.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/BuiltInFormControls/CommitableInput.tsx 🔴 0% 🔴 30.61% 🟢 30.61%
app/javascript/BuiltInFormControls/selectDefaultQueries.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/BuiltInForms/FileUploadForm.tsx 🔴 0% 🟢 80% 🟢 80%
app/javascript/CmsAdmin/CmsFilesAdmin/FileInputWithPreview.tsx 🔴 45.45% 🟢 86.36% 🟢 40.91%
app/javascript/CmsAdmin/CmsFilesAdmin/FilePreview.tsx 🔴 0% 🔴 44.44% 🟢 44.44%
app/javascript/CmsAdmin/CmsPartialsAdmin/mutations.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/EventAdmin/useBucketKeyRemapping.tsx 🔴 0% 🟢 97.06% 🟢 97.06%
app/javascript/EventsApp/EventPage/CreateModeratedSignupModal.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/EventsApp/EventPage/RunCapacityGraphBucket.tsx 🟠 66.67% 🟠 72.22% 🟢 5.55%
app/javascript/EventsApp/EventPage/buildSignupOptions.ts 🟢 87.5% 🟢 90.48% 🟢 2.98%
app/javascript/EventsApp/MySignupQueue/RankedChoicePriorityIndicator.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/EventsApp/MySignupQueue/UserSignupQueueItem.tsx 🔴 0% 🟠 51.16% 🟢 51.16%
app/javascript/EventsApp/MySignupQueue/mutations.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/EventsApp/MySignupQueue/usePendingChoices.tsx 🔴 0% 🟢 83.33% 🟢 83.33%
app/javascript/EventsApp/ScheduleGrid/AvailabilityUtils.tsx 🔴 0% 🔴 48% 🟢 48%
app/javascript/EventsApp/ScheduleGrid/Schedule.ts 🔴 0% 🟢 94.49% 🟢 94.49%
app/javascript/EventsApp/ScheduleGrid/ScheduleGridConfig.ts 🔴 0% 🟢 86.67% 🟢 86.67%
app/javascript/EventsApp/ScheduleGrid/ScheduleGridLayout.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/EventsApp/ScheduleGrid/ScheduleLayout/ColumnReservation.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/EventsApp/ScheduleGrid/ScheduleLayout/ColumnReservationSet.ts 🔴 0% 🟢 92.06% 🟢 92.06%
app/javascript/EventsApp/ScheduleGrid/ScheduleLayout/ScheduleLayoutBlock.ts 🔴 0% 🟢 84.95% 🟢 84.95%
app/javascript/EventsApp/SignupAdmin/$id/change_bucket.tsx 🔴 0% 🟢 90.32% 🟢 90.32%
app/javascript/EventsApp/SignupAdmin/$id/route.tsx 🔴 0% 🟠 70.15% 🟢 70.15%
app/javascript/EventsApp/SignupAdmin/BucketInput.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/EventsApp/SignupAdmin/RunEmailList.tsx 🔴 0% 🟢 92.5% 🟢 92.5%
app/javascript/EventsApp/SignupAdmin/RunSignupSummary.tsx 🔴 0% 🟠 72.73% 🟢 72.73%
app/javascript/EventsApp/SignupAdmin/RunSignupsTable.tsx 🔴 0% 🟢 77.59% 🟢 77.59%
app/javascript/EventsApp/SignupAdmin/SignupUtils.ts 🔴 0% 🟢 95% 🟢 95%
app/javascript/EventsApp/SignupAdmin/loaders.ts 🔴 22.22% 🟢 100% 🟢 77.78%
app/javascript/EventsApp/SignupAdmin/mutations.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/EventsApp/SignupCountData.ts 🟠 72.73% 🟢 100% 🟢 27.27%
app/javascript/EventsApp/TeamMemberAdmin/ProvidableTicketTypeSelection.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/EventsApp/TeamMemberAdmin/ProvideTicketUtils.ts 🔴 0% 🟢 90.91% 🟢 90.91%
app/javascript/EventsApp/TeamMemberAdmin/TicketingStatusDescription.tsx 🔴 0% 🟠 71.43% 🟢 71.43%
app/javascript/FormAdmin/$id/edit/section/$sectionId/NewFormItemModal.tsx 🔴 0% 🟢 88.52% 🟢 88.52%
app/javascript/FormAdmin/FormEditorContexts.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/FormAdmin/FormItemUtils.ts 🔴 24% 🟢 95% 🟢 71%
app/javascript/FormAdmin/ItemEditors/FormItemIdentifierInput.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/FormAdmin/buildNewFormItem.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/FormPresenter/ItemInputs/RegistrationPolicyItemInput.tsx 🔴 0% 🔴 7.14% 🟢 7.14%
app/javascript/FormPresenter/ItemInputs/RequiredIndicator.tsx 🟠 66.67% 🟢 100% 🟢 33.33%
app/javascript/FormPresenter/ItemInteractionTracker.tsx 🟢 90.91% 🟢 100% 🟢 9.09%
app/javascript/FormPresenter/Layouts/FormBody.tsx 🟠 57.58% 🟠 60.61% 🟢 3.03%
app/javascript/Gravatar.tsx 🔴 0% 🟠 66.67% 🟢 66.67%
app/javascript/Models/deserializeFormResponse.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/NavigationBar/useAutoCloseOnNavigate.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/RegistrationPolicy/PreventNoPreferenceSignupRow.tsx 🟠 75% 🟢 91.67% 🟢 16.67%
app/javascript/RegistrationPolicy/RegistrationPolicy.ts 🟢 88.89% 🟢 81.82% 🔴 -7.07%
app/javascript/RegistrationPolicy/RegistrationPolicyBucket.ts 🟠 66.67% 🟢 93.33% 🟢 26.66%
app/javascript/RegistrationPolicy/RegistrationPolicyEditor.tsx 🟢 86.67% 🟢 87.27% 🟢 0.6%
app/javascript/RegistrationPolicy/RegistrationPolicyUtils.ts 🟢 82.61% 🟢 83.33% 🟢 0.72%
app/javascript/ScheduledValueUtils.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/SignupModeration/CreateSignupRunCard.tsx 🔴 0% 🟠 67.86% 🟢 67.86%
app/javascript/SignupModeration/SignupModerationQueue.tsx 🔴 0% 🟠 70.24% 🟢 70.24%
app/javascript/SignupModeration/mutations.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/SignupModeration/queries.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/SignupRoundUtils.ts 🔴 0% 🔴 13.33% 🟢 13.33%
app/javascript/SignupRoundsAdmin/RankedChoiceSignupDecisionsPage.tsx 🔴 0% 🔴 9.88% 🟢 9.88%
app/javascript/SignupRoundsAdmin/queries.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/SortableUtils.tsx 🔴 0% 🟠 50% 🟢 50%
app/javascript/Store/ApplyCouponControl.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Store/Cart/CartContents.tsx 🔴 0% 🟢 93.75% 🟢 93.75%
app/javascript/Store/Cart/coupon_applications/$id.ts 🔴 0% 🟠 75% 🟢 75%
app/javascript/Store/Cart/coupon_applications/route.ts 🔴 0% 🟢 91.67% 🟢 91.67%
app/javascript/Store/Cart/index.tsx 🔴 0% 🟢 95.56% 🟢 95.56%
app/javascript/Store/Cart/order_entries/$id.ts 🔴 0% 🟢 92.86% 🟢 92.86%
app/javascript/Store/MoneyInput.tsx 🔴 3.45% 🟠 62.07% 🟢 58.62%
app/javascript/Store/OrderAdmin/AdminOrderForm.tsx 🔴 0% 🔴 9.52% 🟢 9.52%
app/javascript/Store/OrderHistory.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Store/OrderPaymentModal.tsx 🔴 0% 🟢 97.06% 🟢 97.06%
app/javascript/Store/OrderSummary.tsx 🔴 0% 🟢 97.37% 🟢 97.37%
app/javascript/Store/ProductAdmin/queries.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/Store/ProductOrderForm.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Store/ProductPage.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Store/buildMoneyInput.ts 🔴 0% 🟠 66.67% 🟢 66.67%
app/javascript/Store/describeCoupon.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/Store/describePricingStructure.tsx 🔴 0% 🟢 90.77% 🟢 90.77%
app/javascript/Store/mutations.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/Store/sortProductVariants.ts 🔴 9.09% 🔴 45.45% 🟢 36.36%
app/javascript/Store/useSubmitOrder.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/Tables/BucketChangeCell.tsx 🔴 0% 🟢 87.5% 🟢 87.5%
app/javascript/Tables/ChoiceSetFilter.tsx 🔴 0% 🟠 62.5% 🟢 62.5%
app/javascript/Tables/ColumnSelector.tsx 🔴 0% 🟠 72.73% 🟢 72.73%
app/javascript/Tables/EmailCell.tsx 🔴 0% 🟠 50% 🟢 50%
app/javascript/Tables/ExportButton.tsx 🔴 0% 🔴 8.93% 🟢 8.93%
app/javascript/Tables/FilterUtils.ts 🔴 0% 🔴 16.07% 🟢 16.07%
app/javascript/Tables/FreeTextFilter.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Tables/ReactTableWithTheWorks.tsx 🔴 0% 🟠 57.14% 🟢 57.14%
app/javascript/Tables/SignupStateCell.tsx 🔴 0% 🟠 71.43% 🟢 71.43%
app/javascript/Tables/TableHeader.tsx 🔴 0% 🟢 87.5% 🟢 87.5%
app/javascript/Tables/TableUtils.ts 🔴 0% 🟠 66.67% 🟢 66.67%
app/javascript/Tables/TimestampCell.tsx 🔴 0% 🔴 41.67% 🟢 41.67%
app/javascript/Tables/UserConProfileWithGravatarCell.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Tables/useColumnSelection.tsx 🔴 0% 🟠 56.25% 🟢 56.25%
app/javascript/Tables/useGraphQLReactTable.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/Tables/useLocalStorageReactTable.tsx 🔴 0% 🟢 91.67% 🟢 91.67%
app/javascript/Tables/useReactRouterReactTable.tsx 🔴 0% 🟠 63.64% 🟢 63.64%
app/javascript/Tables/useReactTableWithTheWorks.tsx 🔴 0% 🟢 94.12% 🟢 94.12%
app/javascript/TimeUtils.ts 🟠 58.49% 🟠 71.7% 🟢 13.21%
app/javascript/Timespan.ts 🟢 85.37% 🟢 87.8% 🟢 2.43%
app/javascript/UIComponents/BlockPartial.tsx 🔴 0% 🔴 44.12% 🟢 44.12%
app/javascript/UIComponents/DropdownMenu.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/UIComponents/EmailList.tsx 🔴 0% 🟢 90% 🟢 90%
app/javascript/UserConProfiles/ConvertToEventProvidedTicketModal.tsx 🔴 0% 🟢 89.47% 🟢 89.47%
app/javascript/UserConProfiles/EditUserConProfile.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/UserConProfiles/UserConProfileAdminDisplay.tsx 🔴 0% 🔴 34.38% 🟢 34.38%
app/javascript/UserConProfiles/UserConProfileForm.tsx 🔴 0% 🟢 100% 🟢 100%
app/javascript/UserConProfiles/buildFormStateFromData.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/UserConProfiles/mutations.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/UserConProfiles/queries.generated.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/formatMoney.ts 🔴 0% 🟢 88.89% 🟢 88.89%
app/javascript/humanize.ts 🔴 0% 🟠 75% 🟢 75%
app/javascript/parseCmsContent.tsx 🔴 40% 🔴 44% 🟢 4%
app/javascript/parsePageContent.tsx 🔴 4.42% 🟢 94.69% 🟢 90.27%
app/javascript/setupI18Next.ts 🟠 65.52% 🟢 79.31% 🟢 13.79%
app/javascript/useAsyncFunction.ts 🟢 93.75% 🟢 94.74% 🟢 0.99%
app/javascript/useCachedLoadableValue.ts 🔴 0% 🟢 100% 🟢 100%
app/javascript/usePageTitle.ts 🔴 0% 🟢 100% 🟢 100%
app/liquid_drops/bucket_availability_drop.rb 🔴 0% 🟢 77.78% 🟢 77.78%
app/liquid_drops/run_availability_drop.rb 🔴 0% 🟠 70.59% 🟢 70.59%
app/models/concerns/names.rb 🟠 62.5% 🟢 93.75% 🟢 31.25%
app/models/coupon.rb 🟠 66.67% 🟠 70.37% 🟢 3.7%
app/models/email_route.rb 🟢 79.31% 🟢 93.1% 🟢 13.79%
app/models/event.rb 🟢 79.57% 🟢 85.57% 🟢 6%
app/models/form_item.rb 🟢 90.91% 🟢 94.55% 🟢 3.64%
app/models/registration_policy.rb 🟢 98.59% 🟢 98.72% 🟢 0.13%
app/models/registration_policy_bucket.rb 🟢 98.08% 🟢 96.15% 🔴 -1.93%
app/models/signup.rb 🟢 90.28% 🟢 89.86% 🔴 -0.42%
app/models/signup_request.rb 🟢 95.83% 🟢 96.3% 🟢 0.47%
app/models/user.rb 🟢 88.89% 🟢 96.3% 🟢 7.41%
app/models/user_con_profile.rb 🟠 68.14% 🟠 70.8% 🟢 2.66%
app/notifiers/orders/cancelled_notifier.rb 🟢 86.67% 🟢 93.33% 🟢 6.66%
app/policies/application_policy.rb 🟢 93.94% 🟢 94.74% 🟢 0.8%
app/policies/coupon_application_policy.rb 🔴 0% 🟢 100% 🟢 100%
app/policies/coupon_policy.rb 🔴 0% 🟢 100% 🟢 100%
app/policies/department_policy.rb 🟠 50% 🟢 88.89% 🟢 38.89%
app/policies/email_route_policy.rb 🟠 66.67% 🟢 100% 🟢 33.33%
app/policies/event_rating_policy.rb 🟢 78.57% 🟢 100% 🟢 21.43%
app/policies/notification_template_policy.rb 🟠 50% 🟢 100% 🟢 50%
app/policies/order_entry_policy.rb 🟢 80% 🟢 100% 🟢 20%
app/policies/order_policy.rb 🟢 94.87% 🟢 97.37% 🟢 2.5%
app/policies/ranked_choice_decision_policy.rb 🔴 0% 🟢 100% 🟢 100%
app/policies/ranked_choice_user_constraint_policy.rb 🔴 0% 🟢 100% 🟢 100%
app/policies/signup_change_policy.rb 🟠 66.67% 🟢 100% 🟢 33.33%
app/policies/signup_ranked_choice_policy.rb 🔴 0% 🟢 100% 🟢 100%
app/policies/signup_round_policy.rb 🔴 0% 🟢 100% 🟢 100%
app/policies/user_activity_alert_policy.rb 🟢 77.78% 🟢 100% 🟢 22.22%
app/policies/user_con_profile_policy.rb 🟢 91.55% 🟢 100% 🟢 8.45%
app/presenters/form_response_presenter.rb 🟢 89.8% 🟢 94.23% 🟢 4.43%
app/presenters/run_availability_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/conventions_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/coupons_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/email_routes_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/event_proposals_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/events_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/form_items.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/orders_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/ranked_choice_decisions_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/runs_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/signup_changes_table_results_presenter.rb 🟢 79.31% 🟢 100% 🟢 20.69%
app/presenters/tables/signup_requests_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/signups_table_results_presenter.rb 🟠 67.16% 🟢 100% 🟢 32.84%
app/presenters/tables/table_results_presenter.rb 🟢 77.88% 🟢 100% 🟢 22.12%
app/presenters/tables/user_con_profiles_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/presenters/tables/users_table_results_presenter.rb 🔴 0% 🟢 100% 🟢 100%
app/services/accept_event_proposal_service.rb 🟢 97.87% 🟢 100% 🟢 2.13%
app/services/cancel_order_service.rb 🔴 0% 🟢 100% 🟢 100%
app/services/concerns/split_ticket_order.rb 🔴 0% 🟢 100% 🟢 100%
app/services/connect_stripe_account_service.rb 🔴 0% 🟢 100% 🟢 100%
app/services/delete_ticket_service.rb 🔴 0% 🟢 96.15% 🟢 96.15%
app/services/event_change_registration_policy_service.rb 🟢 91.96% 🟢 92.66% 🟢 0.7%
app/services/import_convention_data_service.rb 🟢 97.11% 🟢 97.13% 🟢 0.02%
app/services/merge_users_service.rb 🟢 96.25% 🟢 100% 🟢 3.75%
app/services/signup_bucket_finder.rb 🟢 81.69% 🟢 81.43% 🔴 -0.26%
app/services/submit_order_service.rb 🟢 87.1% 🟢 93.55% 🟢 6.45%
app/services/turnstile_verification_service.rb 🔴 0% 🟢 89.66% 🟢 89.66%
Overall Coverage 🟢 55.94% 🟢 52.59% 🔴 -3.35%

Minimum allowed coverage is 0%, this run produced 52.59%

@nbudin
nbudin merged commit 67f9e20 into main Oct 5, 2026
24 checks passed
@nbudin
nbudin deleted the test-modals-and-forward-email branch October 5, 2026 18:29
@nbudin nbudin mentioned this pull request Oct 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

frontend patch Bumps the patch version number on release tech debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nbudin